Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 975193002: Restart Chrome if active kiosk app has been removed from policy. (Closed)

Created:
5 years, 9 months ago by Vladislav Kaznacheev
Modified:
5 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restart Chrome if active kiosk app has been removed from policy. BUG=439285 Committed: https://crrev.com/d8d00377c60669198d2a58eade51ae8edd15fc6d Cr-Commit-Position: refs/heads/master@{#318986}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 1 5 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Vladislav Kaznacheev
Hi Xiyuan, Please see if this make sense. This takes care of first half of ...
5 years, 9 months ago (2015-03-03 23:34:47 UTC) #2
xiyuan
lgtm Works for me. https://chromiumcodereview.appspot.com/975193002/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc File chrome/browser/chromeos/app_mode/kiosk_app_manager.cc (right): https://chromiumcodereview.appspot.com/975193002/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc#newcode554 chrome/browser/chromeos/app_mode/kiosk_app_manager.cc:554: it != old_apps.end(); ++it) { ...
5 years, 9 months ago (2015-03-03 23:59:59 UTC) #3
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/975193002/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc File chrome/browser/chromeos/app_mode/kiosk_app_manager.cc (right): https://chromiumcodereview.appspot.com/975193002/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc#newcode554 chrome/browser/chromeos/app_mode/kiosk_app_manager.cc:554: it != old_apps.end(); ++it) { On 2015/03/03 23:59:59, xiyuan ...
5 years, 9 months ago (2015-03-04 00:24:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975193002/20001
5 years, 9 months ago (2015-03-04 00:26:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 00:57:32 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:58:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8d00377c60669198d2a58eade51ae8edd15fc6d
Cr-Commit-Position: refs/heads/master@{#318986}

Powered by Google App Engine
This is Rietveld 408576698