Chromium Code Reviews

Issue 975183002: MIPS compiler flags: use -mfp32 or -mfp64 only if -mhard-float is used. (Closed)

Created:
5 years, 9 months ago by wtc
Modified:
5 years, 9 months ago
Reviewers:
brettw, petarj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MIPS compiler flags: use -mfp32, -mfp64, or -mfpxx only if -mhard-float is used. -mfp32, -mfp64, and -mfpxx only make sense if the FPU is used. R=brettw@chromium.org,petarj@mips.com BUG=446234 Committed: https://crrev.com/07fce68bd04aa5b28916f76173b0c6ead60eddde Cr-Commit-Position: refs/heads/master@{#319227}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+7 lines, -7 lines)
M build/common.gypi View 3 chunks +6 lines, -6 lines 1 comment
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 9 (1 generated)
wtc
Please review. This implements Petar's suggestion in https://codereview.chromium.org/883253003/#msg27. Thanks. https://codereview.chromium.org/975183002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/975183002/diff/1/build/common.gypi#newcode2310 build/common.gypi:2310: ...
5 years, 9 months ago (2015-03-03 23:21:41 UTC) #1
brettw
gm lgtm
5 years, 9 months ago (2015-03-04 00:04:34 UTC) #2
petarj
lgtm
5 years, 9 months ago (2015-03-05 01:47:32 UTC) #3
petarj
On 2015/03/05 01:47:32, petarj wrote: > lgtm Nit: This change is applicable for "fpxx" mode ...
5 years, 9 months ago (2015-03-05 01:51:58 UTC) #4
wtc
On 2015/03/05 01:51:58, petarj wrote: > > Nit: This change is applicable for "fpxx" mode ...
5 years, 9 months ago (2015-03-05 01:56:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975183002/1
5 years, 9 months ago (2015-03-05 04:26:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 06:33:50 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 06:34:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07fce68bd04aa5b28916f76173b0c6ead60eddde
Cr-Commit-Position: refs/heads/master@{#319227}

Powered by Google App Engine