Issue 975153002: fn-drawer sometimes doesn't tick closed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 975153002: fn-drawer sometimes doesn't tick closed (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

fn-drawer sometimes doesn't tick closed If there is jank, we might not get a frame time that's just after the last frame, which means we'll stop generating animation frames before hitting 1.0 exactly. In this CL, we introduce state to takeWhile to cancel the stream after emitting the 1.0. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ee8946ab5b8c95fee3d9f51ea6f1466fd355878b

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	sky/examples/fn/widgets/animationgenerator.dart	View	1	3 chunks	+10 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-03 23:45:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ee8946ab5b8c95fee3d9f51ea6f1466fd355878b (presubmit successful).