Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 975133003: Set Message{Is,Expects} response correctly in go bindings (Closed)

Created:
5 years, 9 months ago by jamesr
Modified:
5 years, 9 months ago
Reviewers:
rogulenko
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Set Message{Is,Expects} response correctly in go bindings We should set MessageExpectsResponse in the proxy when generating an outgoing message and MessageIsResponse when generating the reply. R=rogulenko@google.com Committed: https://chromium.googlesource.com/external/mojo/+/af171018862b466573e98b89e46191dcf89f49b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/public/tools/bindings/generators/go_templates/interface.tmpl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
echo.mojom has this: interface Echo { EchoString(string? value) => (string? value); }; the generated code ...
5 years, 9 months ago (2015-03-03 23:36:06 UTC) #1
jamesr
On 2015/03/03 23:36:06, jamesr wrote: > echo.mojom has this: > > interface Echo { > ...
5 years, 9 months ago (2015-03-03 23:36:53 UTC) #2
rogulenko
lgtm
5 years, 9 months ago (2015-03-04 00:21:18 UTC) #3
jamesr
5 years, 9 months ago (2015-03-04 00:23:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af171018862b466573e98b89e46191dcf89f49b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698