Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 975133002: Revert: Implement declarative content script API for <webview> [js part]. (Closed)

Created:
5 years, 9 months ago by Xi Han
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert: Implement declarative content script API for <webview> [js part]: https://codereview.chromium.org/718203005/ <webview> tag will not support declarative content script API anymore. Instead, we would like to support dynamically add/remove content scripts, which are similar to content scripts for Chrome Extension. BUG=461052 Committed: https://crrev.com/19e4765aa1aa7499dc9a9e35f0090d700f1e377c Cr-Commit-Position: refs/heads/master@{#318972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -95 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/chrome_web_view_experimental.js View 2 chunks +0 lines, -49 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 2 chunks +0 lines, -33 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view.js View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_events.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Xi Han
Hi Fady: PTAL, thanks!
5 years, 9 months ago (2015-03-03 22:24:31 UTC) #2
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-03 22:26:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975133002/1
5 years, 9 months ago (2015-03-03 22:28:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 00:14:42 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:15:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19e4765aa1aa7499dc9a9e35f0090d700f1e377c
Cr-Commit-Position: refs/heads/master@{#318972}

Powered by Google App Engine
This is Rietveld 408576698