chrome/tools/BUILD.gn - Issue 975123003: Add remaining trivial targets for the Linux GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/BUILD.gn

Issue 975123003: Add remaining trivial targets for the Linux GN build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up to make new stuff linux-only for now Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/tools/BUILD.gn

diff --git a/chrome/tools/BUILD.gn b/chrome/tools/BUILD.gn

index 0adca4b06bdcfa133da30339871953b2d893d99f..12bcbf89ffecb12f233b8685c238a142ff80cf6c 100644

--- a/chrome/tools/BUILD.gn

+++ b/chrome/tools/BUILD.gn

@@ -6,8 +6,10 @@

# the build.

group("tools") {

testonly = true

- deps = [

- # TODO(GYP) re-enable this. Currently it's giving linker errors about Mojo.

- #"//chrome/tools/service_discovery_sniffer",

- ]

+ if (is_linux && !is_chromeos) {

+ # TODO(GYP): Figure out which of these work and are needed on other platforms.

+ deps = [

+ "//chrome/tools/service_discovery_sniffer",

+ ]

+ }

}

« BUILD.gn ('K') | « chrome/test/perf/perf_test.gyp ('k') | components/BUILD.gn » ('j') | no next file with comments »