Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 975123003: Add remaining trivial targets for the Linux GN build (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
dtu, brettw
CC:
chromium-reviews, zea+watch_chromium.org, hguihot+watch_chromium.org, mikhal+watch_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, cbentzel+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, piman+watch_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, pwestin+watch_google.com, telemetry-reviews_chromium.org, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remaining trivial targets for the Linux GN build This patch adds a whole bunch of small targets that had either already been done but weren't mentioned in the 'gn_all' group, or needed to be done. In theory this should produce no change on any platform other than Linux, except for one small windows target. R=brettw@chromium.org TBR=dtu@chromium.org BUG=432959 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/db5527d777f1e0cdbaec2bca579bec33aaf7497e Cr-Commit-Position: refs/heads/master@{#319580}

Patch Set 1 #

Patch Set 2 : first pass at android, chromeos #

Patch Set 3 : first pass at win #

Patch Set 4 : first pass at mac #

Patch Set 5 : merge to #319523 #

Patch Set 6 : clean up to make new stuff linux-only for now #

Total comments: 2

Patch Set 7 : fix tap_proxy on chromeos #

Patch Set 8 : fix dependency check for cacheinvalidation #

Patch Set 9 : build html_viewer_tests only in a release build #

Patch Set 10 : merge to #319549, delete //chrome/test:perf #

Patch Set 11 : only build //mojo/services/network in release #

Patch Set 12 : fix other debug/component woes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+935 lines, -165 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +307 lines, -8 lines 0 comments Download
M base/BUILD.gn View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
M base/base.gyp View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 4 12 chunks +180 lines, -152 lines 0 comments Download
A build/sanitizers/BUILD.gn View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
M build/secondary/third_party/cacheinvalidation/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +4 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/tools/BUILD.gn View 1 2 3 4 5 1 chunk +6 lines, -4 lines 0 comments Download
M components/BUILD.gn View 1 2 3 4 5 1 chunk +59 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/session_manager.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M content/content.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/BUILD.gn View 2 chunks +23 lines, -0 lines 0 comments Download
M gpu/tools/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/BUILD.gn View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
A sync/tools/BUILD.gn View 1 2 3 4 5 1 chunk +63 lines, -0 lines 0 comments Download
M sync/tools/sync_tools.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
A tools/perf/clear_system_cache/BUILD.gn View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (20 generated)
brettw
lgtm https://codereview.chromium.org/975123003/diff/100001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/975123003/diff/100001/BUILD.gn#newcode555 BUILD.gn:555: group("gn_visibility") { I don't understand what this is ...
5 years, 9 months ago (2015-03-07 00:42:04 UTC) #3
Dirk Pranke
https://codereview.chromium.org/975123003/diff/100001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/975123003/diff/100001/BUILD.gn#newcode555 BUILD.gn:555: group("gn_visibility") { On 2015/03/07 00:42:03, brettw wrote: > I ...
5 years, 9 months ago (2015-03-07 00:46:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975123003/100001
5 years, 9 months ago (2015-03-07 01:03:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975123003/110023
5 years, 9 months ago (2015-03-07 02:23:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975123003/150001
5 years, 9 months ago (2015-03-07 03:09:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/3206) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-07 03:13:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975123003/170001
5 years, 9 months ago (2015-03-07 03:23:11 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48038)
5 years, 9 months ago (2015-03-07 03:41:46 UTC) #20
Dirk Pranke
tbr'ing dtu for OWNERS approval of tools/perf/clear_system_cache.
5 years, 9 months ago (2015-03-07 17:49:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975123003/170001
5 years, 9 months ago (2015-03-07 17:50:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975123003/190001
5 years, 9 months ago (2015-03-07 17:57:13 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/50125)
5 years, 9 months ago (2015-03-07 19:50:01 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975123003/210001
5 years, 9 months ago (2015-03-08 02:54:21 UTC) #33
commit-bot: I haz the power
Committed patchset #12 (id:210001)
5 years, 9 months ago (2015-03-08 04:22:57 UTC) #34
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 04:23:57 UTC) #35
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/db5527d777f1e0cdbaec2bca579bec33aaf7497e
Cr-Commit-Position: refs/heads/master@{#319580}

Powered by Google App Engine
This is Rietveld 408576698