Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 975043003: [MacViews] Add NativeAppWindowViewsMac and port HideWithApp behavior from NativeAppWindowCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@views
Patch Set: Address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index 2d326957fefba8c18cd2c0390d505a9d12921d54..c00aca75966a5efadb4cc68eaff1096b6b6d8640 100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -2303,6 +2303,14 @@
'browser/ui/views/website_settings/website_settings_popup_view.cc',
'browser/ui/views/website_settings/website_settings_popup_view.h',
],
+ # MacViews sources that we still want to keep behind a compile-time flag.
+ # TODO(jackhou): Move items to chrome_browser_ui_views_sources when they
+ # migrate from mac_views_browser to a chrome://flag.
+ 'chrome_browser_ui_views_mac_sources': [
tapted 2015/03/04 04:13:34 this name isn't quite right - I'd save `chrome_bro
jackhou1 2015/03/04 04:37:13 Done.
+ 'browser/ui/views/apps/chrome_app_window_client_views_mac.mm',
+ 'browser/ui/views/apps/chrome_native_app_window_views_mac.h',
+ 'browser/ui/views/apps/chrome_native_app_window_views_mac.mm',
+ ],
# Windows-only. Assume ash/aura/views.
'chrome_browser_ui_win_sources': [
'browser/ui/network_profile_bubble.cc',
@@ -2851,9 +2859,7 @@
['OS=="mac"', {
'conditions': [
['mac_views_browser==1', {
- 'sources': [
- 'browser/ui/views/apps/chrome_app_window_client_views_mac.mm',
- ],
+ 'sources': [ '<@(chrome_browser_ui_views_mac_sources)' ],
'sources!': [
'browser/ui/cocoa/apps/chrome_app_window_client_cocoa.mm',
'browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm',
« no previous file with comments | « chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698