Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 974933002: content: Refactor ChildThreadImpl::Options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/gpu/gpu_child_thread.cc ('k') | content/utility/utility_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index a5d7e58f3518103e619b12796fa08729eb116095..3f3e5301ac54f9ea3bf5a3fa09538e3d7121ba15 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -433,18 +433,29 @@ RenderThreadImpl* RenderThreadImpl::current() {
// When we run plugins in process, we actually run them on the render thread,
// which means that we need to make the render thread pump UI events.
RenderThreadImpl::RenderThreadImpl()
- : ChildThreadImpl(Options(ShouldUseMojoChannel())) {
+ : ChildThreadImpl(Options::Builder()
+ .InBrowserProcess(true)
+ .UseMojoChannel(ShouldUseMojoChannel())
+ .Build()) {
Init();
}
RenderThreadImpl::RenderThreadImpl(const std::string& channel_name)
- : ChildThreadImpl(Options(channel_name, ShouldUseMojoChannel())) {
+ : ChildThreadImpl(Options::Builder()
+ .InBrowserProcess(true)
+ .UseMojoChannel(ShouldUseMojoChannel())
+ .WithChannelName(channel_name)
+ .Build()) {
Init();
}
RenderThreadImpl::RenderThreadImpl(
scoped_ptr<base::MessageLoop> main_message_loop)
- : ChildThreadImpl(Options(ShouldUseMojoChannel())),
+ : ChildThreadImpl(Options::Builder()
+ // TODO(skyostil): This should be set to false.
+ .InBrowserProcess(true)
+ .UseMojoChannel(ShouldUseMojoChannel())
+ .Build()),
main_message_loop_(main_message_loop.Pass()) {
Init();
}
« no previous file with comments | « content/gpu/gpu_child_thread.cc ('k') | content/utility/utility_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698