Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 974913006: Upstream NSString+CrStringDrawing changes. (Closed)

Created:
5 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream NSString+CrStringDrawing changes. BUG=None Committed: https://crrev.com/be0e83ad01cedc66a6725d045a53eb6859b9a244 Cr-Commit-Position: refs/heads/master@{#319945}

Patch Set 1 #

Patch Set 2 : Merged with origin/master #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M ui/gfx/ios/NSString+CrStringDrawing.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M ui/gfx/ios/NSString+CrStringDrawing.mm View 1 1 chunk +30 lines, -0 lines 4 comments Download
M ui/gfx/ios/NSString+CrStringDrawing_unittest.mm View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Eugene But (OOO till 7-30)
5 years, 9 months ago (2015-03-05 03:32:49 UTC) #2
Eugene But (OOO till 7-30)
Rohit?
5 years, 9 months ago (2015-03-06 17:45:55 UTC) #3
Eugene But (OOO till 7-30)
On 2015/03/06 17:45:55, eugenebut wrote: > Rohit? Could you please do a codereview.
5 years, 9 months ago (2015-03-09 21:54:41 UTC) #4
rohitrao (ping after 24h)
https://codereview.chromium.org/974913006/diff/20001/ui/gfx/ios/NSString+CrStringDrawing.mm File ui/gfx/ios/NSString+CrStringDrawing.mm (right): https://codereview.chromium.org/974913006/diff/20001/ui/gfx/ios/NSString+CrStringDrawing.mm#newcode45 ui/gfx/ios/NSString+CrStringDrawing.mm:45: return [[self substringToIndex:index - 1] stringByAppendingString:@"…"]; Parens around (index ...
5 years, 9 months ago (2015-03-10 18:35:54 UTC) #5
rohitrao (ping after 24h)
LGTM https://codereview.chromium.org/974913006/diff/20001/ui/gfx/ios/NSString+CrStringDrawing.mm File ui/gfx/ios/NSString+CrStringDrawing.mm (right): https://codereview.chromium.org/974913006/diff/20001/ui/gfx/ios/NSString+CrStringDrawing.mm#newcode59 ui/gfx/ios/NSString+CrStringDrawing.mm:59: if (sizeGuess.height > bounds.height) { Oh, I think ...
5 years, 9 months ago (2015-03-10 18:37:21 UTC) #6
Eugene But (OOO till 7-30)
https://codereview.chromium.org/974913006/diff/20001/ui/gfx/ios/NSString+CrStringDrawing.mm File ui/gfx/ios/NSString+CrStringDrawing.mm (right): https://codereview.chromium.org/974913006/diff/20001/ui/gfx/ios/NSString+CrStringDrawing.mm#newcode45 ui/gfx/ios/NSString+CrStringDrawing.mm:45: return [[self substringToIndex:index - 1] stringByAppendingString:@"…"]; On 2015/03/10 18:35:53, ...
5 years, 9 months ago (2015-03-10 18:45:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974913006/20001
5 years, 9 months ago (2015-03-10 18:46:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 19:40:11 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 19:42:18 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/be0e83ad01cedc66a6725d045a53eb6859b9a244
Cr-Commit-Position: refs/heads/master@{#319945}

Powered by Google App Engine
This is Rietveld 408576698