Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: sky/examples/fn/widgets/menuitem.dart

Issue 974903005: attempt at making menuitems react (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rationalise my local client and upload the result Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/fn/widgets/material.dart ('k') | sky/examples/fn/widgets/radio.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/fn/widgets/menuitem.dart
diff --git a/sky/examples/fn/widgets/menuitem.dart b/sky/examples/fn/widgets/menuitem.dart
index e1ca1a0f9d104d64255b35c77830a71df29bcaae..22cd8f75aa060f396d5debd1fd602fa515958902 100644
--- a/sky/examples/fn/widgets/menuitem.dart
+++ b/sky/examples/fn/widgets/menuitem.dart
@@ -1,14 +1,24 @@
part of widgets;
-class MenuItem extends Component {
+class MenuItem extends ButtonBase {
static Style _style = new Style('''
+ transform: translateX(0);
display: flex;
align-items: center;
height: 48px;
-webkit-user-select: none;'''
);
+ static Style _highlightStyle = new Style('''
+ transform: translateX(0);
+ display: flex;
+ align-items: center;
+ height: 48px;
+ background: rgba(153, 153, 153, 0.4);
+ -webkit-user-select: none;'''
+ );
+
static Style _iconStyle = new Style('''
padding: 0px 16px;'''
);
@@ -23,13 +33,20 @@ class MenuItem extends Component {
List<Node> children;
String icon;
- MenuItem({ Object key, this.icon, this.children }) : super(key: key) {
+ sky.EventListener onClick;
+
+ MenuItem({ Object key, this.icon, this.children, this.onClick }) : super(key: key) {
}
Node render() {
return new Container(
- style: _style,
+ style: _highlight ? _highlightStyle : _style,
+ onClick: onClick,
+ onPointerDown: _handlePointerDown,
+ onPointerUp: _handlePointerUp,
+ onPointerCancel: _handlePointerCancel,
children: [
+ super.render(),
new Icon(
style: _iconStyle,
size: 24,
« no previous file with comments | « sky/examples/fn/widgets/material.dart ('k') | sky/examples/fn/widgets/radio.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698