Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 974903005: attempt at making menuitems react (Closed)

Created:
5 years, 9 months ago by Hixie
Modified:
5 years, 9 months ago
Reviewers:
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

fn: make menu items have material splashes also, by factoring out the splashes TBR=raf Committed: https://chromium.googlesource.com/external/mojo/+/4faca498512c01841e3b42a512504c9e8bb423fb

Patch Set 1 #

Patch Set 2 : fix style rules #

Patch Set 3 : factor out material design #

Patch Set 4 : make menu items splash as well #

Patch Set 5 : rationalise my local client and upload the result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -59 lines) Patch
M sky/examples/fn/widgets/button.dart View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M sky/examples/fn/widgets/buttonbase.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/checkbox.dart View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M sky/examples/fn/widgets/drawer.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A sky/examples/fn/widgets/material.dart View 1 2 3 1 chunk +81 lines, -0 lines 0 comments Download
M sky/examples/fn/widgets/menuitem.dart View 1 2 2 chunks +20 lines, -3 lines 0 comments Download
M sky/examples/fn/widgets/radio.dart View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M sky/examples/fn/widgets/widgets.dart View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M sky/examples/stocks-fn/stockrow.dart View 1 2 2 chunks +2 lines, -53 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hixie
5 years, 9 months ago (2015-03-03 22:12:19 UTC) #1
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
4faca498512c01841e3b42a512504c9e8bb423fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698