Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 974903004: [Extensions] Update closure compiler developerPrivate extern with enums (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update closure compiler developerPrivate extern with enums Update the closure compiler extern for the developerPrivate API to have enum definitions, now that enums are exposed on the api object. Update chrome://extensions to use these enums. BUG=463184 BUG=461039 Committed: https://crrev.com/b875af1cd2652ae3e7f633de928b27bf0563d9bb Cr-Commit-Position: refs/heads/master@{#318968}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -24 lines) Patch
M chrome/browser/resources/extensions/pack_extension_overlay.js View 5 chunks +11 lines, -11 lines 0 comments Download
M third_party/closure_compiler/externs/developer_private.js View 1 5 chunks +35 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
As promised. :)
5 years, 9 months ago (2015-03-03 17:45:23 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/974903004/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (right): https://codereview.chromium.org/974903004/diff/1/third_party/closure_compiler/externs/developer_private.js#newcode8 third_party/closure_compiler/externs/developer_private.js:8: // enum defintiions. definitions
5 years, 9 months ago (2015-03-03 18:07:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974903004/20001
5 years, 9 months ago (2015-03-03 23:57:39 UTC) #6
Devlin
https://codereview.chromium.org/974903004/diff/1/third_party/closure_compiler/externs/developer_private.js File third_party/closure_compiler/externs/developer_private.js (right): https://codereview.chromium.org/974903004/diff/1/third_party/closure_compiler/externs/developer_private.js#newcode8 third_party/closure_compiler/externs/developer_private.js:8: // enum defintiions. On 2015/03/03 18:07:58, Dan Beam wrote: ...
5 years, 9 months ago (2015-03-03 23:58:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 00:05:39 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:06:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b875af1cd2652ae3e7f633de928b27bf0563d9bb
Cr-Commit-Position: refs/heads/master@{#318968}

Powered by Google App Engine
This is Rietveld 408576698