Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 974903003: [S.P.] Merge getContentPicture into createContentPicture. (Closed)

Created:
5 years, 9 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, slimming-paint-reviews_chromium.org, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[S.P.] Merge getContentPicture into createContentPicture. BUG=462077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191268

Patch Set 1 #

Patch Set 2 : reverse if condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M Source/core/layout/svg/LayoutSVGResourceMasker.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 1 2 chunks +13 lines, -17 lines 0 comments Download
M Source/core/paint/SVGMaskPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Erik Dahlström (inactive)
5 years, 9 months ago (2015-03-03 16:34:57 UTC) #2
fs
I think I would've reversed the if-condition, but LGTM.
5 years, 9 months ago (2015-03-03 16:41:42 UTC) #3
pdr.
On 2015/03/03 at 16:41:42, fs wrote: > I think I would've reversed the if-condition, but ...
5 years, 9 months ago (2015-03-03 18:20:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974903003/20001
5 years, 9 months ago (2015-03-04 08:02:25 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 09:20:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191268

Powered by Google App Engine
This is Rietveld 408576698