[Sync] Have SyncableService's take ownership of their SyncChangeProcessor.

tools/heapcheck/suppressions.txt

 # There are three kinds of suppressions in this file.
 # 1. third party stuff we have no control over
 #
 # 2. intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 #
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
@@ skipping 1748 matching lines @@
    Heapcheck:Leak
    fun:AppLauncherButton
    fun:ash::internal::LauncherView::CreateViewForItem
    fun:ash::internal::LauncherView::Init
    fun:Launcher
    fun:ash::Shell::Init
    fun:ash::Shell::CreateInstance
    fun:chromeos::DesktopNotificationsTest::SetUp
 }
 {
-   bug_117098_a
-   Heapcheck:Leak
-   fun:base::internal::WeakReferenceOwner::GetRef
-   fun:base::SupportsWeakPtr::AsWeakPtr
-   fun:ProfileSyncServicePreferenceTest::StartSyncService
-}
-{
-   bug_117098_b
-   Heapcheck:Leak
-   fun:__gnu_cxx::new_allocator::allocate
-   fun:std::_Vector_base::_M_allocate
-   fun:std::vector::_M_insert_aux
-   fun:std::vector::push_back
-   fun:browser_sync::GenericChangeProcessor::ApplyChangesFromSyncModel
-}
-{
-   bug_117098_c
-   Heapcheck:Leak
-   fun:CreateAndSaveChangeProcessorActionP::gmock_Impl::gmock_PerformImpl
-   fun:testing::internal::ActionHelper::Perform
-   fun:CreateAndSaveChangeProcessorActionP::gmock_Impl::Perform
-   fun:testing::Action::Perform
-   fun:testing::internal::ActionResultHolder::PerformAction
-   fun:testing::internal::FunctionMockerBase::UntypedPerformAction
-   fun:testing::internal::UntypedFunctionMockerBase::UntypedInvokeWith
-   fun:testing::internal::FunctionMockerBase::InvokeWith
-   fun:testing::internal::FunctionMocker::Invoke
-   fun:ProfileSyncComponentsFactoryMock::CreateGenericChangeProcessor
-   fun:browser_sync::UIDataTypeController::Associate
-   fun:browser_sync::UIDataTypeController::Start
-   fun:browser_sync::DataTypeManagerImpl::StartNextType
-   fun:browser_sync::DataTypeManagerImpl::DownloadReady
-}
-{
    bug_117389
    Heapcheck:Leak
    ...
    fun:TestURLRequestContextGetter::GetURLRequestContext
    ...
    fun:notifier::Login::StartConnection
    fun:sync_notifier::InvalidationNotifier::UpdateCredentials
    fun:sync_notifier::NonBlockingInvalidationNotifier::Core::UpdateCredentials
 }
 {
@@ skipping 10 matching lines @@
    fun:net::HostResolverImpl::CacheResult
    fun:net::HostResolverImpl::Job::CompleteRequests
    fun:net::HostResolverImpl::Job::OnProcTaskComplete
 }
 {
    bug_118336
    Heapcheck:Leak
    ...
    fun:SelectFileDialogExtensionTest_SelfDeleting_Test::TestBody
 }