[Sync] Have SyncableService's take ownership of their SyncChangeProcessor.

chrome/browser/sync/profile_sync_service_preference_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
@@ skipping 23 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_pref_service.h"
 #include "chrome/test/base/testing_profile.h"
 #include "sync/protocol/preference_specifics.pb.h"
 #include "sync/syncable/model_type.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::JSONReader;
 using browser_sync::GenericChangeProcessor;
+using browser_sync::SharedChangeProcessor;
 using browser_sync::UIDataTypeController;
-using browser_sync::SyncBackendHost;
 using sync_api::ChangeRecord;
 using testing::_;
 using testing::Invoke;
 using testing::Return;
 
 typedef std::map<const std::string, const Value*> PreferenceValues;
 
 ACTION_P(CreateAndSaveChangeProcessor, change_processor) {
   sync_api::UserShare* user_share = arg0->GetUserShare();
   *change_processor = new GenericChangeProcessor(arg1, arg2, user_share);
@@ skipping 71 matching lines @@
       return false;
     EXPECT_CALL(*factory, GetSyncableServiceForType(syncable::PREFERENCES)).
         WillOnce(Return(pref_sync_service_->AsWeakPtr()));
 
     EXPECT_CALL(*factory, CreateDataTypeManager(_, _)).
         WillOnce(ReturnNewDataTypeManager());
     dtc_ = new UIDataTypeController(syncable::PREFERENCES,
                                     factory,
                                     profile_.get(),
                                     service_.get());
-     EXPECT_CALL(*factory, CreateGenericChangeProcessor(_, _, _)).
-         WillOnce(CreateAndSaveChangeProcessor(&change_processor_));
+    EXPECT_CALL(*factory, CreateSharedChangeProcessor()).
+        WillOnce(Return(new SharedChangeProcessor()));
+    EXPECT_CALL(*factory, CreateGenericChangeProcessor(_, _, _)).
+        WillOnce(CreateAndSaveChangeProcessor(&change_processor_));
     service_->RegisterDataTypeController(dtc_);
     TokenServiceFactory::GetForProfile(profile_.get())->IssueAuthTokenForTest(
         GaiaConstants::kSyncService, "token");
 
     service_->Initialize();
     MessageLoop::current()->Run();
     return true;
   }
 
   const Value& GetPreferenceValue(const std::string& name) {
@@ skipping 419 matching lines @@
   EXPECT_FALSE(pref->IsDefaultValue());
   // There should be no synced value.
   EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
   // Switch kHomePage back to unmanaged.
   profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage);
   // The original value should be picked up.
   EXPECT_TRUE(pref->IsDefaultValue());
   // There should still be no synced value.
   EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
 }