Issue 974883002: Revert of Fix crash in SimpleGeolocationProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 974883002: Revert of Fix crash in SimpleGeolocationProvider. (Closed)

Created:
5 years, 9 months ago by ulan

Modified:
5 years, 9 months ago

Reviewers:
Alexander Alekseev, Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix crash in SimpleGeolocationProvider. (patchset #1 id:1 of https://codereview.chromium.org/973003002/) Reason for revert: This broke chromeos_unittests (see crbug.com/463499) Original issue's description: > Fix crash in SimpleGeolocationProvider. > > BUG=463150 > TEST=manual > > Committed: https://crrev.com/ae10a9150af37a77ed8e9a71b19ad441d48f1cc7 > Cr-Commit-Position: refs/heads/master@{#318866} TBR=nkostylev@chromium.org,alemate@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463150 Committed: https://crrev.com/cc05c24d7af4d43477d9d50957ae7cec40c618cb Cr-Commit-Position: refs/heads/master@{#318870}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -14 lines)			Patch
	M	chromeos/geolocation/simple_geolocation_provider.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
	M	chromeos/timezone/timezone_provider.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974883002/1

5 years, 9 months ago (2015-03-03 14:37:12 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-03 14:38:53 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cc05c24d7af4d43477d9d50957ae7cec40c618cb
Cr-Commit-Position: refs/heads/master@{#318870}