Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 974873002: MIPS: Move stack unwinding logic into the runtime. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Move stack unwinding logic into the runtime. Port 4acbc93dbfe338adb217f4971e914f77afe504d9 BUG= Committed: https://crrev.com/978c7a8280d3220604ad054a70431c4cbf8a9282 Cr-Commit-Position: refs/heads/master@{#26967}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -280 lines) Patch
M src/mips/code-stubs-mips.cc View 1 4 chunks +59 lines, -34 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -95 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 4 chunks +59 lines, -34 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-03 14:38:11 UTC) #2
dusmil.imgtec
LGTM.
5 years, 9 months ago (2015-03-03 15:16:56 UTC) #3
Michael Starzinger
LGTM. https://codereview.chromium.org/974873002/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/974873002/diff/1/src/mips/code-stubs-mips.cc#newcode1053 src/mips/code-stubs-mips.cc:1053: // Ask the runtime for help to determine ...
5 years, 9 months ago (2015-03-03 15:23:22 UTC) #4
balazs.kilvady
Thanks for catching comment mistakes.
5 years, 9 months ago (2015-03-03 16:16:36 UTC) #5
balazs.kilvady
https://codereview.chromium.org/974873002/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/974873002/diff/1/src/mips/code-stubs-mips.cc#newcode1053 src/mips/code-stubs-mips.cc:1053: // Ask the runtime for help to determine the ...
5 years, 9 months ago (2015-03-03 16:17:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974873002/20001
5 years, 9 months ago (2015-03-03 16:17:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 17:15:19 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 17:15:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/978c7a8280d3220604ad054a70431c4cbf8a9282
Cr-Commit-Position: refs/heads/master@{#26967}

Powered by Google App Engine
This is Rietveld 408576698