Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 974863002: [Gin] Add a warning about potential memory leak for CreateFunctionTemplate (Closed)

Created:
5 years, 9 months ago by mnaganov (inactive)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Gin] Add a warning about potential memory leak for CreateFunctionTemplate Whether to actually cache the template depends on the use case, so only adding a warning in a comment. BUG=463487 Committed: https://crrev.com/098ba6f53d540c16953724a027a1e05dcd20ecc8 Cr-Commit-Position: refs/heads/master@{#318889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M gin/function_template.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
5 years, 9 months ago (2015-03-03 13:43:29 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-03 13:56:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974863002/1
5 years, 9 months ago (2015-03-03 15:23:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 16:34:55 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:36:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/098ba6f53d540c16953724a027a1e05dcd20ecc8
Cr-Commit-Position: refs/heads/master@{#318889}

Powered by Google App Engine
This is Rietveld 408576698