Issue 974853002: The Global Load IC doesn't yet play well with --vector-ics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 974853002: The Global Load IC doesn't yet play well with --vector-ics. (Closed)

Created:
5 years, 9 months ago by mvstanton

Modified:
5 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

The Global Load IC doesn't yet play well with --vector-ics. Until this is addressed, we can simply use the regular IC, as we do in times of serialization. R=verwaest@chromium.org Committed: https://crrev.com/d232dcfd6a838fe016d1634db717d7ea9f453231 Cr-Commit-Position: refs/heads/master@{#26977}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/full-codegen.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	src/ic/ic.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

mvstanton

Hi Toon, Here is a quick mitigation CLz, thx for the look, --Michael

5 years, 9 months ago (2015-03-03 13:42:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974853002/1

5 years, 9 months ago (2015-03-04 08:46:36 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-04 09:41:31 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d232dcfd6a838fe016d1634db717d7ea9f453231
Cr-Commit-Position: refs/heads/master@{#26977}