Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 974803002: Defer addStubs to class instantiation time. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased and fixes. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 08fa0a74db29be482239a6f7e62b6111c4bfc36d..61701c3e9f2cc2f6c9499f4d36fa7ef1c0bb801c 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -702,7 +702,7 @@ class JavaScriptBackend extends Backend {
* Record that [method] is called from a subclass via `super`.
*/
bool maybeRegisterAliasedSuperMember(Element member, Selector selector) {
- if (selector.isGetter || compiler.hasIncrementalSupport) {
+ if (!canUseAliasedSuperMember(member, selector)) {
// Invoking a super getter isn't supported, this would require changes to
// compact field descriptors in the emitter.
// We also turn off this optimization in incremental compilation, to
@@ -714,6 +714,10 @@ class JavaScriptBackend extends Backend {
return true;
}
+ bool canUseAliasedSuperMember(Element member, Selector selector) {
+ return !selector.isGetter && !compiler.hasIncrementalSupport;
+ }
+
/**
* Returns `true` if [member] is called from a subclass via `super`.
*/
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698