Defer addStubs to class instantiation time.

sdk/lib/_internal/compiler/js_lib/js_names.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart._js_names;
 
 import 'dart:_js_embedded_names' show
     JsGetName,
     MANGLED_GLOBAL_NAMES,
     MANGLED_NAMES;
 
 import 'dart:_foreign_helper' show
     JS,
     JS_EMBEDDED_GLOBAL,
     JS_GET_NAME;
 
 import 'dart:_js_helper' show
     JsCache,
     NoInline;
 
 import 'dart:_interceptors' show JSArray;
 
 /// No-op method that is called to inform the compiler that unmangled named
 /// must be preserved.
 preserveNames() {}
 
 /// A map from mangled names to "reflective" names, that is, unmangled names
 /// with some additional information, such as, number of required arguments.
 /// This map is for mangled names used as instance members.
-final Map<String, String> mangledNames =
-    computeMangledNames(
-        JS_EMBEDDED_GLOBAL('=Object', MANGLED_NAMES),
-        false);
+final _LazyMangledNamesMap mangledNames = new _LazyMangledInstanceNamesMap(
+    JS_EMBEDDED_GLOBAL('=Object', MANGLED_NAMES));
 
 /// A map from "reflective" names to mangled names (the reverse of
 /// [mangledNames]).
-final Map<String, String> reflectiveNames =
-    computeReflectiveNames(mangledNames);
+final _LazyReflectiveNamesMap reflectiveNames =
+    new _LazyReflectiveNamesMap(JS_EMBEDDED_GLOBAL('=Object', MANGLED_NAMES),
+        true);
 
 /// A map from mangled names to "reflective" names (see [mangledNames]).  This
 /// map is for globals, that is, static and top-level members.
-final Map<String, String> mangledGlobalNames = computeMangledNames(
-        JS_EMBEDDED_GLOBAL('=Object', MANGLED_GLOBAL_NAMES),
-        true);
+final _LazyMangledNamesMap mangledGlobalNames = new _LazyMangledNamesMap(
+    JS_EMBEDDED_GLOBAL('=Object', MANGLED_GLOBAL_NAMES));
 
 /// A map from "reflective" names to mangled names (the reverse of
 /// [mangledGlobalNames]).
-final Map<String, String> reflectiveGlobalNames =
-    computeReflectiveNames(mangledGlobalNames);
+final _LazyReflectiveNamesMap reflectiveGlobalNames =
+    new _LazyReflectiveNamesMap(
+        JS_EMBEDDED_GLOBAL('=Object', MANGLED_GLOBAL_NAMES), false);
 
+/// Implements a mapping from mangled names to their refletive counterparts.

[floitsch, 2015/03/11 13:59:34]

reflective

[herhut, 2015/03/13 12:28:52]

Done.

 /// [jsMangledNames] is a JavaScript object literal.  The keys are the mangled
 /// names, and the values are the "reflective" names.
-Map<String, String> computeMangledNames(jsMangledNames, bool isGlobal) {
-  preserveNames();
-  var keys = extractKeys(jsMangledNames);
-  var result = <String, String>{};
-  String getterPrefix = JS_GET_NAME(JsGetName.GETTER_PREFIX);
-  int getterPrefixLength = getterPrefix.length;
-  String setterPrefix = JS_GET_NAME(JsGetName.SETTER_PREFIX);
-  for (String key in keys) {
-    String value = JS('String', '#[#]', jsMangledNames, key);
-    result[key] = value;
-    if (!isGlobal) {
-      if (key.startsWith(getterPrefix)) {
-        result['$setterPrefix${key.substring(getterPrefixLength)}'] = '$value=';
+class _LazyMangledNamesMap {
+  var _jsMangledNames;

[floitsch, 2015/03/11 13:59:34]

Document what type it is here (and not in the dartdoc of the class).

[herhut, 2015/03/13 12:28:52]

Done.

+
+  _LazyMangledNamesMap(this._jsMangledNames);
+
+  String operator[](String key) {
+    String result = JS('var', '#[#]', _jsMangledNames, key);
+    // Filter out all non-string values to protect against polution from
+    // anciliary fields in [_jsMangledNames].
+    bool filter =
+        JS('bool', 'typeof # !== "string"', result);
+    return filter ? null : result;

[floitsch, 2015/03/11 13:59:34]

You should type it, so that the inferrer realizes that this must be a string.

[herhut, 2015/03/13 12:28:53]

Done.

+  }
+}
+
+/// Extends [_LazyMangledNamesMap] with additional support for adding mappings
+/// from mangled setter names to their reflective counterpart by rewriting a
+/// corresponding entry for a getter name, if it exists.
+class _LazyMangledInstanceNamesMap extends _LazyMangledNamesMap {
+  _LazyMangledInstanceNamesMap(_jsMangledNames) : super(_jsMangledNames);
+
+  String operator[](String key) {
+    String result = super[key];
+    String setterPrefix = JS_GET_NAME(JsGetName.SETTER_PREFIX);
+    if (result == null && key.startsWith(setterPrefix)) {
+      String getterPrefix = JS_GET_NAME(JsGetName.GETTER_PREFIX);
+      int setterPrefixLength = getterPrefix.length;

[floitsch, 2015/03/11 13:59:34]

getterPrefixLength ?
(If not explain)

[herhut, 2015/03/13 12:28:52]

Done.

+
+      // Generate the setter name from the getter name.
+      key = '$getterPrefix${key.substring(setterPrefixLength)}';
+      result = super[key];
+      return (result != null) ? "${result}=" : null;
+    }
+    return result;
+  }
+}
+
+/// Implements the inverse of [_LazyMangledNamesMap]. As it would be too
+/// expensive to seach the mangled names map for a value that corresponds to
+/// the lookup key on each invocation, we compute the full mapping in demand
+/// and cache it. The cache is invalidated when the underlying [_jsMangledNames]
+/// object changes its lenght. This condition is sufficient as the name mapping

[floitsch, 2015/03/11 13:59:34]

length

[herhut, 2015/03/13 12:28:52]

Done.

+/// can only grow over time.
+/// When [_isInstance] is true, we also apply the inverse of the setter/getter
+/// name conversion implemented by [_LazyMangledInstanceNamesMap].
+class _LazyReflectiveNamesMap {
+  final _jsMangledNames;

[floitsch, 2015/03/11 13:59:34]

Document what (type) this field is.

[herhut, 2015/03/13 12:28:52]

Done.

+  final bool _isInstance;
+  int _cacheLength = 0;
+  Map<String, String> _cache;
+
+  _LazyReflectiveNamesMap(this._jsMangledNames, this._isInstance);
+
+  Map<String, String> _updateReflectiveNames() {
+    preserveNames();
+    Map<String, String> result = <String, String>{};
+    List keys = JS('List', 'Object.keys(#)', _jsMangledNames);
+    for (String key in keys) {
+      var reflectiveName = JS('var', '#[#]', _jsMangledNames, key);
+      // Filter out all non-string values to protect against polution from
+      // anciliary fields in [_jsMangledNames].
+      bool filter = JS('bool', '# == null || typeof # !== "string"',
+          reflectiveName, reflectiveName);
+      if (filter) continue;
+      result[reflectiveName] = key;

[floitsch, 2015/03/11 13:59:34]

ditto: make sure that the type is known.

[herhut, 2015/03/13 12:28:52]

Done.

+
+      String getterPrefix = JS_GET_NAME(JsGetName.GETTER_PREFIX);
+      if (_isInstance && key.startsWith(getterPrefix)) {
+        int getterPrefixLength = getterPrefix.length;
+        String setterPrefix = JS_GET_NAME(JsGetName.SETTER_PREFIX);
+        result['$reflectiveName='] =
+            '$setterPrefix${key.substring(getterPrefixLength)}';
       }
     }
+    return result;
   }
-  return result;
-}
 
-Map<String, String> computeReflectiveNames(Map<String, String> map) {
-  preserveNames();
-  var result = <String, String>{};
-  map.forEach((String mangledName, String reflectiveName) {
-    result[reflectiveName] = mangledName;
-  });
-  return result;
+  int get _jsMangledNamesLength => JS('int', '#.length', _jsMangledNames);
+
+  String operator[](String key) {
+    if (_cache == null || _jsMangledNamesLength != _cacheLength) {
+      _cache = _updateReflectiveNames();
+      _cacheLength = _jsMangledNamesLength;
+    }
+    return _cache[key];
+  }
 }
 
 @NoInline()
 List extractKeys(victim) {
   var result = JS('', '# ? Object.keys(#) : []', victim, victim);
   return new JSArray.markFixed(result);
 }
 
 /**
  * Returns the (global) unmangled version of [name].
@@ skipping 11 matching lines @@
   return JsCache.fetch(names, name);
 }
 
 String unmangleAllIdentifiersIfPreservedAnyways(String str) {
   return JS("String",
             r"(#).replace(/[^<,> ]+/g,"
             r"function(m) { return #[m] || m; })",
             str,
             JS_EMBEDDED_GLOBAL('', MANGLED_GLOBAL_NAMES));
 }