Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 974783003: Speed up parsing of smis (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Speed up parsing of smis BUG= Committed: https://crrev.com/84b36933c56af637cd595fa9b5186016b8209dbe Cr-Commit-Position: refs/heads/master@{#26956}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Consume smi as smi and complete the literal for turning it into a symbol #

Patch Set 4 : Ignore partially parsed octal-seeming decimal numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M src/parser.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/preparser.h View 1 2 5 chunks +9 lines, -2 lines 0 comments Download
M src/scanner.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/scanner.cc View 1 2 3 3 chunks +17 lines, -0 lines 0 comments Download
M src/token.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-03 10:16:59 UTC) #2
Yang
On 2015/03/03 10:16:59, Toon Verwaest wrote: > PTAL lgtm.
5 years, 9 months ago (2015-03-03 10:18:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974783003/60001
5 years, 9 months ago (2015-03-03 10:34:12 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-03 11:04:54 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 11:05:10 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/84b36933c56af637cd595fa9b5186016b8209dbe
Cr-Commit-Position: refs/heads/master@{#26956}

Powered by Google App Engine
This is Rietveld 408576698