LayoutTests/fullscreen/rendering/style-defaults-iframe.html - Issue 974783002: Match the Fullscreen spec's CSS as far as currently practical

Unified Diff: LayoutTests/fullscreen/rendering/style-defaults-iframe.html

Issue 974783002: Match the Fullscreen spec's CSS as far as currently practical (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fullscreen/full-screen-render-inline-expected.html ('K') | « LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html ('k') | LayoutTests/fullscreen/rendering/style-defaults-root.html » ('j') | LayoutTests/fullscreen/rendering/style-defaults-root.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fullscreen/rendering/style-defaults-iframe.html

diff --git a/LayoutTests/fullscreen/rendering/style-defaults-iframe.html b/LayoutTests/fullscreen/rendering/style-defaults-iframe.html

new file mode 100644

index 0000000000000000000000000000000000000000..60f3fff77bdef42a0b3c04e2b71b2e3913d8bb64

--- /dev/null

+++ b/LayoutTests/fullscreen/rendering/style-defaults-iframe.html

@@ -0,0 +1,56 @@

+<!DOCTYPE html>

+<title>User-agent level style sheet defaults for an iframe</title>

Julien - ping for review 2015/03/04 01:07:37 Using <title> is useless in test. If it is meaning

philipj_slow 2015/03/04 07:15:28 With testharness.js the <title> becomes the test t

Julien - ping for review 2015/03/04 17:50:22 Can you include the output of these tests? I think

philipj_slow 2015/03/05 04:05:06 There's a hook to prevent all-passing testharness.

There's a hook to prevent all-passing testharness.js expectations from being checked in, but see below for what they look like after some more renaming.

OK, just name of the section in the spec wasn't clear. It was hard to come up with a title for the override+border test, so I've split those. The three tests now have these test expectations: This is a testharness.js-based test. PASS Fullscreen UA style sheet removes iframe border Harness: the test ran to completion. This is a testharness.js-based test. PASS Fullscreen UA style sheet cannot be overriden by author style Harness: the test ran to completion. This is a testharness.js-based test. PASS Fullscreen UA style sheet does not apply to the :root element Harness: the test ran to completion.

Julien - ping for review 2015/03/05 18:19:03 OK, I think that's OK. It's kinda weird to dump th

On 2015/03/05 04:05:06, philipj_UTC7 wrote: > On 2015/03/04 17:50:22, Julien Chaffraix - PST wrote: > > On 2015/03/04 07:15:28, philipj_UTC7 wrote: > > > On 2015/03/04 01:07:37, Julien Chaffraix - PST wrote: > > > > Using <title> is useless in test. If it is meaningful, it should be dumped > > in > > > > the final output. If not, it should be removed. > > > > > > With testharness.js the <title> becomes the test title, equivalent to > putting > > it > > > after the function in async_test. It is included in the test expectations > > ("PASS > > > User-agent level style sheet defaults for an iframe") but those don't need > to > > be > > > checked in for all-passing testharness.js tests. > > > > Can you include the output of these tests? I think I understand what you said > > but I would like to see the output for myself before making up my mind. > > There's a hook to prevent all-passing testharness.js expectations from being > checked in, but see below for what they look like after some more renaming. > > > (Also I would argue it's a bad decision from the W3C harness to have this > > magical behavior for <title> but that's another debate). > > > > > > Also the description doesn't match what you're trying to do. You're not > > > testing > > > > the default at all, you're making sure they can't be overridden. > > > > > > I've renamed the tests to ua-style-*.html, does that work? I think it makes > > > sense to test the defaults and overriding them in the same test, because > > trying > > > to override them is how we verify that !important is included. > > > > I didn't have a gripe with the previous naming but the new name is better > > indeed. > > > > I meant that the content of <title> doesn't match what you're doing. You're > not > > testing the defaults, you're testing that they cannot be overridden. Those are > 2 > > different tests and the description matches the former when you're actually > > testing the latter. > > OK, just name of the section in the spec wasn't clear. It was hard to come up > with a title for the override+border test, so I've split those. The three tests > now have these test expectations: > > This is a testharness.js-based test. > PASS Fullscreen UA style sheet removes iframe border > Harness: the test ran to completion. > > This is a testharness.js-based test. > PASS Fullscreen UA style sheet cannot be overriden by author style > Harness: the test ran to completion. > > This is a testharness.js-based test. > PASS Fullscreen UA style sheet does not apply to the :root element > Harness: the test ran to completion.

OK, I think that's OK. It's kinda weird to dump the description after PASS.

philipj_slow 2015/03/06 02:43:40 This is because it's possible to have multiple tes

On 2015/03/05 18:19:03, Julien Chaffraix - PST wrote: > On 2015/03/05 04:05:06, philipj_UTC7 wrote: > > On 2015/03/04 17:50:22, Julien Chaffraix - PST wrote: > > > On 2015/03/04 07:15:28, philipj_UTC7 wrote: > > > > On 2015/03/04 01:07:37, Julien Chaffraix - PST wrote: > > > > > Using <title> is useless in test. If it is meaningful, it should be > dumped > > > in > > > > > the final output. If not, it should be removed. > > > > > > > > With testharness.js the <title> becomes the test title, equivalent to > > putting > > > it > > > > after the function in async_test. It is included in the test expectations > > > ("PASS > > > > User-agent level style sheet defaults for an iframe") but those don't need > > to > > > be > > > > checked in for all-passing testharness.js tests. > > > > > > Can you include the output of these tests? I think I understand what you > said > > > but I would like to see the output for myself before making up my mind. > > > > There's a hook to prevent all-passing testharness.js expectations from being > > checked in, but see below for what they look like after some more renaming. > > > > > (Also I would argue it's a bad decision from the W3C harness to have this > > > magical behavior for <title> but that's another debate). > > > > > > > > Also the description doesn't match what you're trying to do. You're not > > > > testing > > > > > the default at all, you're making sure they can't be overridden. > > > > > > > > I've renamed the tests to ua-style-*.html, does that work? I think it > makes > > > > sense to test the defaults and overriding them in the same test, because > > > trying > > > > to override them is how we verify that !important is included. > > > > > > I didn't have a gripe with the previous naming but the new name is better > > > indeed. > > > > > > I meant that the content of <title> doesn't match what you're doing. You're > > not > > > testing the defaults, you're testing that they cannot be overridden. Those > are > > 2 > > > different tests and the description matches the former when you're actually > > > testing the latter. > > > > OK, just name of the section in the spec wasn't clear. It was hard to come up > > with a title for the override+border test, so I've split those. The three > tests > > now have these test expectations: > > > > This is a testharness.js-based test. > > PASS Fullscreen UA style sheet removes iframe border > > Harness: the test ran to completion. > > > > This is a testharness.js-based test. > > PASS Fullscreen UA style sheet cannot be overriden by author style > > Harness: the test ran to completion. > > > > This is a testharness.js-based test. > > PASS Fullscreen UA style sheet does not apply to the :root element > > Harness: the test ran to completion. > > OK, I think that's OK. It's kinda weird to dump the description after PASS.

This is because it's possible to have multiple tests in a single file, and in that case you get one PASS (hopefully) with the test title on each line.

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../trusted-event.js"></script>

+<style>

+iframe {

+ /* Try to override everything which is !important in the UA style sheet. */

+ position: relative !important;

+ top: auto !important;

+ right: auto !important;

+ bottom: auto !important;

+ left: auto !important;

+ margin: 10px !important;

+ box-sizing: content-box !important;

+ min-width: 50% !important;

+ max-width: 50% !important;

+ min-height: 50% !important;

+ max-height: 50% !important;

+ object-fit: none !important;

+ border: 1px solid black; /* not !important in the UA style sheet */

+</style>

+<div id="log"></div>

+<iframe></iframe>

+<script>

+async_test(function()

+ var iframe = document.querySelector("iframe");

+ document.addEventListener("fullscreenchange", this.step_func_done(function()

+ {

+ var style = getComputedStyle(iframe);

+ // All properties except border should match the UA style sheet.

+ assert_equals(style.position, "fixed");

+ assert_equals(style.top, "0px");

+ assert_equals(style.right, "0px");

+ assert_equals(style.bottom, "0px");

+ assert_equals(style.left, "0px");

+ assert_equals(style.margin, "0px");

+ assert_equals(style.boxSizing, "border-box");

+ assert_equals(style.minWidth, "0px");

+ assert_equals(style.maxWidth, "none");

+ assert_equals(style.minHeight, "0px");

+ assert_equals(style.maxHeight, "none");

+ assert_equals(style.width, window.innerWidth + "px");

+ assert_equals(style.height, window.innerHeight + "px");

Julien - ping for review 2015/03/04 01:07:37 width and height are not overriden

philipj_slow 2015/03/04 07:15:28 I removed them when I noticed it doesn't make any

+ assert_equals(style.objectFit, "contain");

+ assert_equals(style.flex, "0 0 auto");

Julien - ping for review 2015/03/04 01:07:37 Nor is flex

philipj_slow 2015/03/04 07:15:28 Done.

+ assert_equals(style.transform, "none");

Julien - ping for review 2015/03/04 01:07:37 Nor transform.

philipj_slow 2015/03/04 07:15:28 Done.

+ assert_equals(style.borderStyle, "solid");

+ }));

+ trusted_request(iframe);

+});

+</script>