Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | |
| 2 * User-agent level style sheet defaults for the Fullscreen API | |
| 3 * https://fullscreen.spec.whatwg.org/#user-agent-level-style-sheet-defaults | |
| 4 * | |
| 5 * Note that the prefixed :-webkit-full-screen pseudo-class is used instead of | |
| 6 * :fullscreen. crbug.com/402378 | |
|
Julien - ping for review
2015/03/04 01:07:38
That's not a really actionable (btw the rest of th
philipj_slow
2015/03/04 07:15:28
I'll convert everything to FIXMEs instead.
| |
| 7 */ | |
| 8 | |
| 9 :not(:root):-webkit-full-screen { | |
| 10 position: fixed !important; | |
| 11 top: 0 !important; | |
| 12 right: 0 !important; | |
| 13 bottom: 0 !important; | |
| 14 left: 0 !important; | |
| 15 margin: 0 !important; | |
| 16 box-sizing: border-box !important; | |
| 17 min-width: 0 !important; | |
| 18 max-width: none !important; | |
| 19 min-height: 0 !important; | |
| 20 max-height: none !important; | |
| 21 width: 100% !important; | |
| 22 height: 100% !important; | |
| 23 object-fit: contain !important; | |
| 24 } | |
| 25 | |
| 26 iframe:-webkit-full-screen { | |
| 27 border: none; | |
| 28 } | |
| 29 | |
| 30 /* | |
| 31 * The flex and transform rules will likely be added to the spec: | |
| 32 * https://www.w3.org/Bugs/Public/show_bug.cgi?id=27931 | |
| 33 * Bug history in WebKit and Blink: | |
| 34 * https://bugs.webkit.org/show_bug.cgi?id=58291 | |
| 35 * https://bugs.webkit.org/show_bug.cgi?id=60140 | |
| 36 * https://bugs.webkit.org/show_bug.cgi?id=62463 | |
| 37 * https://crbug.com/356282 | |
|
Julien - ping for review
2015/03/04 01:07:38
The (apparently) semi-random selection of bugs you
philipj_slow
2015/03/04 07:15:28
These were the bugs references when adding/tweakin
| |
| 38 */ | |
| 1 :-webkit-full-screen { | 39 :-webkit-full-screen { |
| 2 background-color: white; | 40 flex: none !important; |
|
Julien - ping for review
2015/03/04 01:07:38
I don't agree with this change nor the justificati
philipj_slow
2015/03/04 07:15:28
OK, I'll revert the background changes.
|
Julien - ping for review
2015/03/04 01:07:38
I would have liked a focused explanation on why it
philipj_slow
2015/03/04 07:15:28
Sorry, I should have declared my ignorance on this
Julien - ping for review
2015/03/04 17:50:22
It was probably not needed before actually but we
philipj_slow
2015/03/05 04:05:06
I've played around a bit with flexbox and the Full
|
| 41 transform: none !important; | |
| 42 } | |
| 43 | |
|
Julien - ping for review
2015/03/04 01:07:38
I would love to keep the separation between spec a
philipj_slow
2015/03/04 07:15:28
Done.
| |
| 44 /* | |
| 45 * Implementing Fullscreen using top layer would remove the need for | |
| 46 * z-index and :-webkit-full-screen-ancestor rules. crbug.com/240576 | |
| 47 */ | |
| 48 :-webkit-full-screen { | |
| 3 z-index: 2147483647 !important; | 49 z-index: 2147483647 !important; |
| 4 } | 50 } |
| 5 | 51 |
| 6 :root:-webkit-full-screen-ancestor { | |
| 7 overflow: hidden !important; | |
| 8 } | |
| 9 | |
| 10 :-webkit-full-screen-ancestor:not(iframe) { | 52 :-webkit-full-screen-ancestor:not(iframe) { |
| 11 z-index: auto !important; | 53 z-index: auto !important; |
| 12 position: static !important; | 54 position: static !important; |
| 13 opacity: 1 !important; | 55 opacity: 1 !important; |
| 14 transform: none !important; | 56 transform: none !important; |
| 15 -webkit-mask: none !important; | 57 -webkit-mask: none !important; |
| 16 clip: none !important; | 58 clip: none !important; |
| 17 -webkit-filter: none !important; | 59 -webkit-filter: none !important; |
| 18 transition: none !important; | 60 transition: none !important; |
| 19 -webkit-box-reflect: none !important; | 61 -webkit-box-reflect: none !important; |
| 20 -webkit-perspective: none !important; | 62 -webkit-perspective: none !important; |
| 21 -webkit-transform-style: flat !important; | 63 -webkit-transform-style: flat !important; |
| 22 } | 64 } |
| 23 | 65 |
| 24 video:-webkit-full-screen, audio:-webkit-full-screen { | 66 /* |
| 25 background-color: transparent !important; | 67 * Prevents video from overflowing the viewport on Android. crbug.com/441890 |
| 26 position: relative !important; | 68 */ |
| 27 left: 0 !important; | 69 :-webkit-full-screen-ancestor { |
| 28 top: 0 ! important; | 70 overflow: hidden !important; |
| 29 margin: 0 !important; | |
| 30 min-width: 0 !important; | |
| 31 max-width: none !important; | |
| 32 min-height: 0 !important; | |
| 33 max-height: none !important; | |
| 34 width: 100% !important; | |
| 35 height: 100% !important; | |
| 36 flex: 1 !important; | |
| 37 display: block !important; | |
| 38 transform: none !important; | |
| 39 } | 71 } |
| 40 | |
| 41 img:-webkit-full-screen { | |
| 42 width: auto; | |
| 43 height: 100%; | |
| 44 max-width: 100%; | |
| 45 } | |
| 46 | |
| 47 iframe:-webkit-full-screen { | |
| 48 margin: 0 !important; | |
| 49 padding: 0 !important; | |
| 50 border: 0 !important; | |
| 51 position: fixed !important; | |
| 52 min-width: 0 !important; | |
| 53 max-width: none !important; | |
| 54 min-height: 0 !important; | |
| 55 max-height: none !important; | |
| 56 width: 100% !important; | |
| 57 height: 100% !important; | |
| 58 left: 0 !important; | |
| 59 top: 0 !important; | |
| 60 } | |
| OLD | NEW |