Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 974733002: Fix gyp analyzer generator on mac. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
bradnelson, sky, scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix gyp analyzer generator on mac. The analzyer was always defaulting to supporting multiple toolsets, unlike the ninja generator, which would only claim to support multiple toolsets conditionally based on the environmental settings (basically if you were actually doing a cross-compile). As a result of this bug, we would get crashes trying to run the analyzer on the mac in some circumstances when trying to build a target that might not otherwise exist. R=scottmg@chromium.org, sky@chromium.org, bradnelson@chromium.org BUG=461811 Committed: https://chromium.googlesource.com/external/gyp/+/4a9b712d5cb4a5ba7a9950128a7219569caf7263

Patch Set 1 #

Patch Set 2 : move multiple-toolset logic into common #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M pylib/gyp/common.py View 1 1 chunk +11 lines, -0 lines 0 comments Download
M pylib/gyp/generator/analyzer.py View 1 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/generator/ninja.py View 1 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-03 03:08:12 UTC) #1
sky
Tricky. LGTM
5 years, 9 months ago (2015-03-03 03:13:27 UTC) #2
Dirk Pranke
scottmg, bradley - can one of you take a look at this?
5 years, 9 months ago (2015-03-03 20:46:03 UTC) #4
scottmg
I don't entirely understand that comment, but I see it's copied from ninja.py. Could you ...
5 years, 9 months ago (2015-03-03 21:19:21 UTC) #5
Dirk Pranke
On 2015/03/03 21:19:21, scottmg wrote: > I don't entirely understand that comment, but I see ...
5 years, 9 months ago (2015-03-03 21:21:00 UTC) #6
Dirk Pranke
5 years, 9 months ago (2015-03-03 22:10:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4a9b712d5cb4a5ba7a9950128a7219569caf7263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698