Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 974723002: OOPIF: Replicate dynamic window.name updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Nasko's nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/data/frame_tree/top.html ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index cb190d9230b27414932897b33d77a9821599d5b6..2612c419eea275bf6403e154f0eef18da2bd121a 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -266,10 +266,10 @@ class WebViewGuest : public GuestView<WebViewGuest>,
bool is_iframe_srcdoc) override;
void DocumentLoadedInFrame(
content::RenderFrameHost* render_frame_host) override;
- bool OnMessageReceived(const IPC::Message& message,
- content::RenderFrameHost* render_frame_host) override;
void RenderProcessGone(base::TerminationStatus status) override;
void UserAgentOverrideSet(const std::string& user_agent) override;
+ void FrameNameChanged(content::RenderFrameHost* render_frame_host,
+ const std::string& name) override;
// Informs the embedder of a frame name change.
void ReportFrameNameChange(const std::string& name);
@@ -308,8 +308,6 @@ class WebViewGuest : public GuestView<WebViewGuest>,
const GURL& url,
const std::string& error_type);
- void OnFrameNameChanged(bool is_top_level, const std::string& name);
-
// Creates a new guest window owned by this WebViewGuest.
void CreateNewGuestWebViewWindow(const content::OpenURLParams& params);
« no previous file with comments | « content/test/data/frame_tree/top.html ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698