content/public/renderer/render_frame_observer.h - Issue 974723002: OOPIF: Replicate dynamic window.name updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 974723002: OOPIF: Replicate dynamic window.name updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Nasko's nits Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/renderer/render_frame_observer.h

diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h

index 1bcc8fdfeb98d8fb434eac848d5479489608c360..85319b202bfc81fab81ae57523ee4b56218ddd98 100644

--- a/content/public/renderer/render_frame_observer.h

+++ b/content/public/renderer/render_frame_observer.h

@@ -55,7 +55,6 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,

virtual void WillReleaseScriptContext(v8::Handle<v8::Context> context,

int world_id) {}

virtual void DidClearWindowObject() {}

- virtual void DidChangeName(const base::string16& name) {}

virtual void DidChangeManifest() {}

virtual void DidChangeScrollOffset() {}

virtual void WillSendSubmitEvent(const blink::WebFormElement& form) {}