content/browser/frame_host/frame_tree_node.cc - Issue 974723002: OOPIF: Replicate dynamic window.name updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 974723002: OOPIF: Replicate dynamic window.name updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Nasko's nits Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/frame_tree_node.cc

diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc

index 80035481e39ec266930ea396077d05cdde8ec49d..cb1c0cc6c7b3792b975161349aed08125ed3554b 100644

--- a/content/browser/frame_host/frame_tree_node.cc

+++ b/content/browser/frame_host/frame_tree_node.cc

@@ -104,6 +104,13 @@ void FrameTreeNode::ResetForNewProcess() {

old_children.clear(); // May notify observers.

}

+void FrameTreeNode::SetFrameName(const std::string& name) {

+ replication_state_.name = name;

+ // Notify this frame's proxies about the updated name.

+ render_manager_.OnDidUpdateName(name);

bool FrameTreeNode::IsDescendantOf(FrameTreeNode* other) const {

if (!other || !other->child_count())

return false;