OOPIF: Replicate dynamic window.name updates.

content/browser/frame_host/render_frame_host_impl.cc

Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 272aeb201995ae28ed0858dccb99fcb673914a50..d34ecc8164817f156e8db71ef9677430c8048b0c 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -369,6 +369,7 @@ bool RenderFrameHostImpl::OnMessageReceived(const IPC::Message &msg) {
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidAccessInitialDocument,
                         OnDidAccessInitialDocument)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidDisownOpener, OnDidDisownOpener)
+    IPC_MESSAGE_HANDLER(FrameHostMsg_DidChangeName, OnDidChangeName)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidAssignPageId, OnDidAssignPageId)
     IPC_MESSAGE_HANDLER(FrameHostMsg_UpdateTitle, OnUpdateTitle)
     IPC_MESSAGE_HANDLER(FrameHostMsg_UpdateEncoding, OnUpdateEncoding)
@@ -1188,6 +1189,14 @@ void RenderFrameHostImpl::OnDidDisownOpener() {
   delegate_->DidDisownOpener(this);
 }
 
+void RenderFrameHostImpl::OnDidChangeName(const std::string& name) {
+  // Update the frame's name in the browser process

[nasko, 2015/03/05 18:09:27]

nit: Comments that explain what the code does when it is mostly obvious
shouldn't be used. Let's remove this one.

[alexmos, 2015/03/09 18:47:58]

Done.

+  frame_tree_node()->set_frame_name(name);
+
+  // Notify this frame's proxies about the updated name.
+  frame_tree_node()->render_manager()->OnDidUpdateName(name);

[nasko, 2015/03/05 18:09:27]

Shouldn't we put this code inside the FTN's method that sets the name? RFH
shouldn't care what needs to happen with this name. It is more of a function of
the FTN that it knows it can have proxies (through its RFHM).

[alexmos, 2015/03/09 18:47:58]

Great point - done.  Renamed FrameTreeNode::set_frame_name() to SetFrameName,
and moved the call to OnDidUpdateName there.

+}
+
 void RenderFrameHostImpl::OnDidAssignPageId(int32 page_id) {
   // Update the RVH's current page ID so that future IPCs from the renderer
   // correspond to the new page.