content/test/data/frame_tree/top.html - Issue 974723002: OOPIF: Replicate dynamic window.name updates.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/frame_tree/top.html

Issue 974723002: OOPIF: Replicate dynamic window.name updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 window.name = "foo";
alexmos 2015/03/04 01:04:22 I removed this to fix FrameTreeBrowserTest.FrameTr I removed this to fix FrameTreeBrowserTest.FrameTreeShape2, which was failing because it was checking the root's frame_name() and expecting it to be empty, but with this line it was ending up as "foo" (correctly, I think). I don't think the "foo" name is used anywhere else in the tests, so I just removed it here rather than fix the expectations. Let me know if this does have a use I don't know about.
5

6 function simulateClick(target) {	4 function simulateClick(target) {

7 var evt = document.createEvent("MouseEvents");	5 var evt = document.createEvent("MouseEvents");

8 evt.initMouseEvent("click", true, true, window,	6 evt.initMouseEvent("click", true, true, window,

9 0, 0, 0, 0, 0, false, false,	7 0, 0, 0, 0, 0, false, false,

10 false, false, 0, null);	8 false, false, 0, null);

11	9

12 return target.dispatchEvent(evt);	10 return target.dispatchEvent(evt);

13 }	11 }

14	12

15 function openWindow(url) {	13 function openWindow(url) {

(...skipping 22 matching lines...) Expand all Loading...
38 <iframe src="1-1.html" name="1-1-name"></iframe>	36 <iframe src="1-1.html" name="1-1-name"></iframe>

39 <br>	37 <br>

40 <iframe src="1-2.html" id="1-2-id" name="1-2-name"></iframe>	38 <iframe src="1-2.html" id="1-2-id" name="1-2-name"></iframe>

41 <br>	39 <br>

42 <iframe src="1-3.html" id="1-3-id"></iframe>	40 <iframe src="1-3.html" id="1-3-id"></iframe>

43 <br>	41 <br>

44	42

45 </html>	43 </html>

46 </body>	44 </body>

47 </html>	45 </html>

OLD	NEW

« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_proxy.cc ('k') | no next file » | no next file with comments »