OOPIF: Replicate dynamic window.name updates.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 2102 matching lines @@
   DCHECK(!frame_ || frame_ == frame);
 
   FOR_EACH_OBSERVER(RenderFrameObserver, observers_, FrameWillClose());
   FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
                     FrameWillClose(frame));
 }
 
 void RenderFrameImpl::didChangeName(blink::WebLocalFrame* frame,
                                     const blink::WebString& name) {
   DCHECK(!frame_ || frame_ == frame);
+
+  // TODO(alexmos): According to https://crbug.com/169110, sending window.name
+  // updates may have performance implications for benchmarks like SunSpider.
+  // For now, send these updates only for --site-per-process, which needs to
+  // replicate frame names to all of this frame's proxies.  This can also be
+  // optimized by only sending the update if there are any remote frames in the
+  // frame tree.
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kSitePerProcess)) {
+    Send(new FrameHostMsg_DidChangeName(routing_id_, base::UTF16ToUTF8(name)));
+  }
+
   if (!render_view_->renderer_preferences_.report_frame_name_changes)
     return;
 
+  // TODO(alexmos): ExtensionsRenderFrameObserver sends another message to the
+  // browser process to keep the <webview> tag's name attribute updated.  It
+  // should be refactored to use the FrameHostMsg_DidChangeName above.
   FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeName(name));

[alexmos, 2015/03/04 01:04:21]

I'm still finalizing what this should be, and it'd be great to get feedback
here.  ExtensionsRenderFrameObserver::DidChangeName  will send another message
ExtensionHostMsg_FrameNameChanged, which is redundant.  I think WebView should
be reusing the more general FrameHostMsg_DidChangeName I'm adding.  We would
then send the message when we're either in --site-per-process, or the WebView
renderer pref is set.  One question, though, is on the browser side, do we have
a way to call something like WebViewGuest::OnFrameNameChanged from a RFH?

[nasko, 2015/03/05 18:09:28]

We don't have such a way and this type of direct call will be a layering
violation. RFH shouldn't know about any of the layers on top of it.

What we can do, though, is expose WebContentsObserver::FrameNameChanged, which
anyone can listen for and take action. I would suggest going that route and
confirming with fsamuel@ it works for them too.

[alexmos, 2015/03/09 18:47:58]

Done.  Refactored WebViewGuest to use WebContentsObserver::FrameNameChanged, and
removed the old plumbing and message.

 }
 
 void RenderFrameImpl::didMatchCSS(
     blink::WebLocalFrame* frame,
     const blink::WebVector<blink::WebString>& newly_matching_selectors,
     const blink::WebVector<blink::WebString>& stopped_matching_selectors) {
   DCHECK(!frame_ || frame_ == frame);
 
   FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
                     DidMatchCSS(frame,
@@ skipping 2318 matching lines @@
 
 #if defined(ENABLE_BROWSER_CDMS)
 RendererCdmManager* RenderFrameImpl::GetCdmManager() {
   if (!cdm_manager_)
     cdm_manager_ = new RendererCdmManager(this);
   return cdm_manager_;
 }
 #endif  // defined(ENABLE_BROWSER_CDMS)
 
 }  // namespace content