kiosk: Ensure launching latest version.

kiosk: Ensure launching latest version.

- Add a install_immediately flag to ExternalProviderImpl;
- Set install_immediately flag to true for kiosk app provider
  so that updated app install is not delayed;
- Set auto acknowledge since kiosk should not show external
  install alert;

BUG=461419
Committed: https://crrev.com/4d82f7b69b1058e9af2696c568fe051d2b22a213
Cr-Commit-Position: refs/heads/master@{#319005}

[xiyuan, 2015-03-03 01:57:37]

xiyuan@chromium.org changed reviewers:
+ jennyz@chromium.org

[jennyz, 2015-03-03 18:09:30]

lgtm

[xiyuan, 2015-03-03 18:15:58]

xiyuan@chromium.org changed reviewers:
+ yoz@chromium.org

[xiyuan, 2015-03-03 18:15:59]

yoz@, could you help with owner's review of external_provider_impl.cc? Kiosk
apps are installed via external provider now and should be auto acknowledged
since we don't want to show the alert or hold the install.

Thanks.

[Yoyo Zhou, 2015-03-03 21:38:23]

https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/external_provider_impl.cc:430: Extension::NO_FLAGS));
I think you should just set the kInstallFlagInstallImmediately flag - no need to
manually call into the install-immediately flow for ExtensionService.

[xiyuan, 2015-03-03 22:04:21]

https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/external_provider_impl.cc:430: Extension::NO_FLAGS));
On 2015/03/03 21:38:23, Yoyo Zhou wrote:
> I think you should just set the kInstallFlagInstallImmediately flag - no need
to
> manually call into the install-immediately flow for ExtensionService.

To do that, it seems we need to add a boolean member to ExternalProviderImpl and
plumb it through OnExternalExtensionFileFound so that the CrxInstaller gets it.

Is there a better way?

[xiyuan, 2015-03-03 22:33:20]

https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/external_provider_impl.cc:430: Extension::NO_FLAGS));
On 2015/03/03 22:04:21, xiyuan wrote:
> On 2015/03/03 21:38:23, Yoyo Zhou wrote:
> > I think you should just set the kInstallFlagInstallImmediately flag - no
need
> to
> > manually call into the install-immediately flow for ExtensionService.
> 
> To do that, it seems we need to add a boolean member to ExternalProviderImpl
and
> plumb it through OnExternalExtensionFileFound so that the CrxInstaller gets
it.
> 
> Is there a better way?

Done. Let me know what you think.

[Yoyo Zhou, 2015-03-03 22:38:56]

On 2015/03/03 22:33:20, xiyuan wrote:
>
https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
> File chrome/browser/extensions/external_provider_impl.cc (right):
> 
>
https://chromiumcodereview.appspot.com/974713002/diff/20001/chrome/browser/ex...
> chrome/browser/extensions/external_provider_impl.cc:430:
Extension::NO_FLAGS));
> On 2015/03/03 22:04:21, xiyuan wrote:
> > On 2015/03/03 21:38:23, Yoyo Zhou wrote:
> > > I think you should just set the kInstallFlagInstallImmediately flag - no
> need
> > to
> > > manually call into the install-immediately flow for ExtensionService.
> > 
> > To do that, it seems we need to add a boolean member to ExternalProviderImpl
> and
> > plumb it through OnExternalExtensionFileFound so that the CrxInstaller gets
> it.
> > 
> > Is there a better way?
> 
> Done. Let me know what you think.

Ah, I see. I misjudged what kind of flag it was. I think this is better though,
so LGTM.

[xiyuan, 2015-03-03 22:42:36]

I've updated the CL description so that it matches the latest patch set.

Thanks guys.

[xiyuan, 2015-03-04 00:00:46]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2015-03-04 00:00:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jennyz@chromium.org,
yoz@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/974713002/#ps60001
(title: "fix unittest compile")

[commit-bot: I haz the power, 2015-03-04 00:02:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/974713002/60001

[commit-bot: I haz the power, 2015-03-04 02:29:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-04 02:30:16]

Patchset 4 (id:??) landed as
https://crrev.com/4d82f7b69b1058e9af2696c568fe051d2b22a213
Cr-Commit-Position: refs/heads/master@{#319005}