Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 974673002: [Chromoting] Add remoting_options.gypi to share vars. (Closed)

Created:
5 years, 9 months ago by garykac
Modified:
5 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Add remoting_options.gypi to share vars. Default vars (like run_jscompile) should only be defined in one place. This cl adds remoting_options.gypi so that the variables can be used by both DesktopRemoting and AppRemoting gyp files. BUG= Committed: https://crrev.com/ff9e4bf4c19b2ae13af4b200ddad52f54c46009e Cr-Commit-Position: refs/heads/master@{#318838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -30 lines) Patch
M remoting/app_remoting_webapp_build.gypi View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/remoting.gyp View 3 chunks +1 line, -26 lines 0 comments Download
A remoting/remoting_options.gypi View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 9 months ago (2015-03-03 01:09:28 UTC) #2
Jamie
lgtm
5 years, 9 months ago (2015-03-03 01:15:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974673002/1
5 years, 9 months ago (2015-03-03 01:52:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 04:04:39 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 04:05:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff9e4bf4c19b2ae13af4b200ddad52f54c46009e
Cr-Commit-Position: refs/heads/master@{#318838}

Powered by Google App Engine
This is Rietveld 408576698