chromecast/media/cma/pipeline/video_pipeline_impl.cc - Issue 974623002: Chromecast: mitigate threading issue between AvPipeline/MediaKeys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/pipeline/video_pipeline_impl.cc

Issue 974623002: Chromecast: mitigate threading issue between AvPipeline/MediaKeys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes some bugs Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/media/cma/pipeline/video_pipeline_impl.cc

diff --git a/chromecast/media/cma/pipeline/video_pipeline_impl.cc b/chromecast/media/cma/pipeline/video_pipeline_impl.cc

index d3ae9bec1a911f9a4050961593010d39302f06c4..3a1c619e733547386212d1efd5891813020548ac 100644

--- a/chromecast/media/cma/pipeline/video_pipeline_impl.cc

+++ b/chromecast/media/cma/pipeline/video_pipeline_impl.cc

@@ -23,9 +23,9 @@ VideoPipelineImpl::VideoPipelineImpl(VideoPipelineDevice* video_device)

: video_device_(video_device),

weak_factory_(this) {

weak_this_ = weak_factory_.GetWeakPtr();

- av_pipeline_impl_.reset(new AvPipelineImpl(

+ av_pipeline_impl_ = new AvPipelineImpl(

video_device_,

- base::Bind(&VideoPipelineImpl::OnUpdateConfig, base::Unretained(this))));

+ base::Bind(&VideoPipelineImpl::OnUpdateConfig, base::Unretained(this)));

}

VideoPipelineImpl::~VideoPipelineImpl() {

« no previous file with comments | « chromecast/media/cma/pipeline/video_pipeline_impl.h ('k') | no next file » | no next file with comments »