Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 974543004: Remove failing test for dragging <video controls> in fullscreen (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
falken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove failing test for dragging <video controls> in fullscreen This is not expected to work, the remnants of the WebKit code that supported dragging were removed a year ago: https://codereview.chromium.org/196533020 BUG=341813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
D LayoutTests/fullscreen/video-controls-drag.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/fullscreen/video-controls-drag-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/android/virtual/android/fullscreen/video-controls-drag-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-drag-expected.png View Binary file 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-03 10:02:25 UTC) #2
falken
lgtm
5 years, 9 months ago (2015-03-04 07:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974543004/1
5 years, 9 months ago (2015-03-04 08:49:39 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 08:52:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191266

Powered by Google App Engine
This is Rietveld 408576698