Issue 974483004: Stocks app shouldn't show black when resuming from recents list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 974483004: Stocks app shouldn't show black when resuming from recents list (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Stocks app shouldn't show black when resuming from recents list Previously, we weren't scheduling a visual update when our surface was created, so we'd just continue to show black until the author requested a new animation frame. After this CL, we schedule a visual update as soon as our surface is created. As part of this change, I've removed knowledge of the GPU delegate from PlatformView. Now, all the calls from PlatformView to the GPU system bounce through the UI delegate, which serializes the commands with other commands from the UI engine to the GPU rasterizer. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b5b67b6dabb996a6958256057281d50410ac348c

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -17 lines)			Patch
M	sky/shell/platform_view.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/shell/platform_view.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	sky/shell/shell.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.cc	View	3 chunks	+20 lines, -5 lines	0 comments	Download
M	sky/shell/ui_delegate.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 9 months ago (2015-03-03 00:25:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b5b67b6dabb996a6958256057281d50410ac348c (presubmit successful).

Expand Messages | Collapse Messages