content/renderer/gpu/frame_swap_message_queue.cc - Issue 974483002: [WebView] Remove onFailure from VisualStateCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/frame_swap_message_queue.cc

Issue 974483002: [WebView] Remove onFailure from VisualStateCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/render_frame_host.h ('K') | « content/public/browser/render_frame_host.h ('k') | content/renderer/gpu/frame_swap_message_queue_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/gpu/frame_swap_message_queue.cc

diff --git a/content/renderer/gpu/frame_swap_message_queue.cc b/content/renderer/gpu/frame_swap_message_queue.cc

index bf91dd84e0f89bdb19c8cb50922547114c474da6..5a313829cb14bdff612db09b06ed67116c6d0fec 100644

--- a/content/renderer/gpu/frame_swap_message_queue.cc

+++ b/content/renderer/gpu/frame_swap_message_queue.cc

@@ -161,10 +161,14 @@ void FrameSwapMessageQueue::DidNotSwap(int source_frame_number,

case cc::SwapPromise::SWAP_FAILS:

case cc::SwapPromise::COMMIT_NO_UPDATE:

swap_queue_->DrainMessages(source_frame_number, messages);

- // fallthrough

- case cc::SwapPromise::COMMIT_FAILS:

visual_state_queue_->DrainMessages(source_frame_number, messages);

break;

+ case cc::SwapPromise::COMMIT_FAILS:

+ // Do not queue any responses here.

+ // If COMMIT_FAILS the renderer is shutting down, which will

+ // result in the RenderFrameHostImpl destructor firing the

+ // remaining response callbacks itself.

+ break;

default:

NOTREACHED();

}