android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java - Issue 974483002: [WebView] Remove onFailure from VisualStateCallback.

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

Issue 974483002: [WebView] Remove onFailure from VisualStateCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/native/aw_contents.cc » ('j') | content/public/browser/render_frame_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

index 3ceeb13c32a11b57c54ae74aa7153ff231821082..00d6849cda5b88d0267fd09663c80eac9f05bef8 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

@@ -59,11 +59,6 @@ public class VisualStateTest extends AwTestBase {

assertEquals(requestId, id);

ch.notifyCalled();

}

- @Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

});

}

});

@@ -90,11 +85,6 @@ public class VisualStateTest extends AwTestBase {

awContentsRef.get().insertVisualStateCallback(requestId,

new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

assertEquals(requestId, id);

Bitmap blueScreenshot = GraphicsTestUtils

@@ -147,11 +137,6 @@ public class VisualStateTest extends AwTestBase {

awContentsRef.get().insertVisualStateCallback(10,

new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

Bitmap blueScreenshot = GraphicsTestUtils.drawAwContents(

awContentsRef.get(), 100, 100);

@@ -191,11 +176,6 @@ public class VisualStateTest extends AwTestBase {

awContents.insertVisualStateCallback(20,

new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

Bitmap redScreenshot = GraphicsTestUtils.drawAwContents(

awContents, 100, 100);

@@ -229,11 +209,6 @@ public class VisualStateTest extends AwTestBase {

super.onPageFinished(url);

awContentsRef.get().insertVisualStateCallback(10, new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

Bitmap blueScreenshot =

GraphicsTestUtils.drawAwContents(awContentsRef.get(), 100, 100);

@@ -271,11 +246,6 @@ public class VisualStateTest extends AwTestBase {

public void run() {

awContents.insertVisualStateCallback(20, new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

// NOTE: We cannot use drawAwContents here because the web contents

// are rendered into the custom view while in fullscreen.

@@ -310,11 +280,6 @@ public class VisualStateTest extends AwTestBase {

super.onPageFinished(url);

awContentsRef.get().insertVisualStateCallback(10, new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

Bitmap blueScreenshot =

GraphicsTestUtils.drawAwContents(awContentsRef.get(), 100, 100);

@@ -329,11 +294,6 @@ public class VisualStateTest extends AwTestBase {

super.onShowCustomView(view, callback);

awContentsRef.get().insertVisualStateCallback(20, new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

// NOTE: We cannot use drawAwContents here because the web contents are

// rendered into the custom view while in fullscreen.