Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 974463003: Revert of Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118) (Closed)

Created:
5 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, alancutter (OOO until 2018), enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118) (patchset #1 id:1 of https://codereview.chromium.org/965793004/) Reason for revert: broke official builds win,linux,mac see http://build.chromium.org/p/chromium/builders/Win/builds/29606/steps/compile/logs/stdio Original issue's description: > Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/f48b013..696617b > > TBR=alancutter@chromium.org,enne@chromium.org > > Committed: https://crrev.com/2f52d5e10d93c872020247c824e01e376999815e > Cr-Commit-Position: refs/heads/master@{#318726} TBR=alancutter@chromium.org,enne@chromium.org,blink-deps-roller@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/68b05046b28e79144fa6d03453c9d5ac93ded402 Cr-Commit-Position: refs/heads/master@{#318742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
cpu_(ooo_6.6-7.5)
Created Revert of Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118)
5 years, 9 months ago (2015-03-02 20:52:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974463003/1
5 years, 9 months ago (2015-03-02 20:52:55 UTC) #2
scottmg
lgtm
5 years, 9 months ago (2015-03-02 20:53:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 20:53:58 UTC) #5
scottmg
In particular, https://chromium.googlesource.com/chromium/blink/+/1327617b741227230b7c9fb5171bf7d902ce8d5d likely broke "no-op compile check" that the clobber builders do.
5 years, 9 months ago (2015-03-02 20:54:02 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 20:54:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68b05046b28e79144fa6d03453c9d5ac93ded402
Cr-Commit-Position: refs/heads/master@{#318742}

Powered by Google App Engine
This is Rietveld 408576698