Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 974453002: Remove [TypeChecking=Unrestricted] use in core/svg/ (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, shans, vivekg_samsung, fs, vivekg, kouhei+svg_chromium.org, rwlbuis, krit, arv+blink, dstockwell, Timothy Loh, pdr+svgwatchlist_chromium.org, Eric Willigers, Steve Block, rjwright, gyuyoung.kim_webkit.org, darktears, blink-reviews-animation_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove [TypeChecking=Unrestricted] use in Source/core/svg/ The IDL compiler has been updated to always generate code that rejects non-finite numbers, so removing [TypeChecking=Unrestricted] does not change generated code. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -37 lines) Patch
M Source/core/svg/SVGAngle.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGLength.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMatrix.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumber.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegArcRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPoint.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRect.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransform.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-02 15:35:03 UTC) #2
fs
Nice! LGTM
5 years, 9 months ago (2015-03-02 15:51:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974453002/1
5 years, 9 months ago (2015-03-02 16:22:01 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:02:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191115

Powered by Google App Engine
This is Rietveld 408576698