Make vpn destroyConfig generate disconnect message for connected configuration

Make vpn destroyConfig generate disconnect message for connected configuration

The CL ensures that when destroyConfig is called for a configuration that is
connected and active, disconnect message is generated before the destroyConfig
is acknowledged.

BUG=462235
Committed: https://crrev.com/a1577e3e4fa24e193c8c3b8b9c581010d9e57b9b
Cr-Commit-Position: refs/heads/master@{#319878}

[kaliamoorthi, 2015-03-02 14:19:24]

Patchset #1 (id:1) has been deleted

[kaliamoorthi, 2015-03-02 14:20:51]

Patchset #1 (id:20001) has been deleted

[kaliamoorthi, 2015-03-02 14:26:19]

kaliamoorthi@chromium.org changed reviewers:
+ bartfab@chromium.org

[kaliamoorthi, 2015-03-02 14:26:19]

PTAL

[kaliamoorthi, 2015-03-05 11:17:51]

Patchset #1 (id:40001) has been deleted

[bartfab (slow), 2015-03-10 13:28:41]

LGTM after you remove OnAppWindowRemoved() and friends.

https://codereview.chromium.org/974443002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/vpn_provider/vpn_service_factory.cc (right):

https://codereview.chromium.org/974443002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/vpn_provider/vpn_service_factory.cc:58:
extensions::AppWindowRegistry::Get(context),
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
File extensions/browser/api/vpn_provider/vpn_service.cc (right):

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.cc:28: #include
"extensions/browser/app_window/app_window.h"
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.cc:141:
extensions::AppWindowRegistry* app_window_registry,
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.cc:150:
app_window_registry_(app_window_registry),
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.cc:159:
app_window_registry_->AddObserver(this);
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.cc:169:
app_window_registry_->RemoveObserver(this);
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.cc:450: void
VpnService::OnAppWindowRemoved(extensions::AppWindow* app_window) {
Nit: As discussed offline, we do not need this.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
File extensions/browser/api/vpn_provider/vpn_service.h (right):

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.h:19: #include
"extensions/browser/app_window/app_window_registry.h"
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.h:38: class AppWindow;
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.h:53: public
extensions::AppWindowRegistry::Observer,
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.h:65:
extensions::AppWindowRegistry* app_window_registry,
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.h:97: 
Nit: Remove blank linke to make it clear that this is also an
|ExtensionRegistryObserver| method.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.h:104: void
OnAppWindowRemoved(extensions::AppWindow* app_window) override;
Nit: As discussed offline, we do not need this.

https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
extensions/browser/api/vpn_provider/vpn_service.h:208:
extensions::AppWindowRegistry* app_window_registry_;
Nit: No longer needed.

https://codereview.chromium.org/974443002/diff/60001/extensions/shell/browser...
File extensions/shell/browser/api/vpn_provider/vpn_service_factory.cc (right):

https://codereview.chromium.org/974443002/diff/60001/extensions/shell/browser...
extensions/shell/browser/api/vpn_provider/vpn_service_factory.cc:52:
extensions::AppWindowRegistry::Get(context),
Nit: No longer needed.

[kaliamoorthi, 2015-03-10 13:43:10]

Patchset #2 (id:80001) has been deleted

[kaliamoorthi, 2015-03-10 13:45:49]

On 2015/03/10 13:28:41, bartfab wrote:
> LGTM after you remove OnAppWindowRemoved() and friends.
> 
>
https://codereview.chromium.org/974443002/diff/60001/chrome/browser/extension...
> File chrome/browser/extensions/api/vpn_provider/vpn_service_factory.cc
(right):
> 
>
https://codereview.chromium.org/974443002/diff/60001/chrome/browser/extension...
> chrome/browser/extensions/api/vpn_provider/vpn_service_factory.cc:58:
> extensions::AppWindowRegistry::Get(context),
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> File extensions/browser/api/vpn_provider/vpn_service.cc (right):
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.cc:28: #include
> "extensions/browser/app_window/app_window.h"
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.cc:141:
> extensions::AppWindowRegistry* app_window_registry,
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.cc:150:
> app_window_registry_(app_window_registry),
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.cc:159:
> app_window_registry_->AddObserver(this);
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.cc:169:
> app_window_registry_->RemoveObserver(this);
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.cc:450: void
> VpnService::OnAppWindowRemoved(extensions::AppWindow* app_window) {
> Nit: As discussed offline, we do not need this.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> File extensions/browser/api/vpn_provider/vpn_service.h (right):
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.h:19: #include
> "extensions/browser/app_window/app_window_registry.h"
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.h:38: class AppWindow;
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.h:53: public
> extensions::AppWindowRegistry::Observer,
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.h:65:
> extensions::AppWindowRegistry* app_window_registry,
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.h:97: 
> Nit: Remove blank linke to make it clear that this is also an
> |ExtensionRegistryObserver| method.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.h:104: void
> OnAppWindowRemoved(extensions::AppWindow* app_window) override;
> Nit: As discussed offline, we do not need this.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/browser/api/v...
> extensions/browser/api/vpn_provider/vpn_service.h:208:
> extensions::AppWindowRegistry* app_window_registry_;
> Nit: No longer needed.
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/shell/browser...
> File extensions/shell/browser/api/vpn_provider/vpn_service_factory.cc (right):
> 
>
https://codereview.chromium.org/974443002/diff/60001/extensions/shell/browser...
> extensions/shell/browser/api/vpn_provider/vpn_service_factory.cc:52:
> extensions::AppWindowRegistry::Get(context),
> Nit: No longer needed.

Thanks Bartosz. Fixed all your comments in the new CL.

[kaliamoorthi, 2015-03-10 13:46:34]

The CQ bit was checked by kaliamoorthi@chromium.org

[kaliamoorthi, 2015-03-10 13:46:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bartfab@chromium.org
Link to the patchset: https://codereview.chromium.org/974443002/#ps100001
(title: "Fixed comments from Bartosz")

[commit-bot: I haz the power, 2015-03-10 13:46:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/974443002/100001

[commit-bot: I haz the power, 2015-03-10 14:19:56]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2015-03-10 14:20:37]

Patchset 2 (id:??) landed as
https://crrev.com/a1577e3e4fa24e193c8c3b8b9c581010d9e57b9b
Cr-Commit-Position: refs/heads/master@{#319878}