Add --force-in-process flag to shell.

Add --force-in-process flag to shell.

(Don't force anything by default yet, since things currently work
without doing so.)

The URLs given to the flag are mapped and resolved. An application is
loaded in-process if its actual (mapped, resolved, possibly redirected)
URL matches a mapped and resolved URL. (This matching scheme may fail if
requesting the mapped and resolved URL results in a redirect.)

Still to do (separately): lots of cleanup (renaming, reducing
indirection, simplifying).

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/fbf0a4ee9c117d4ea25ea2654ff5aaac3936ab40

[jamesr, 2015-03-04 20:55:25]

https://codereview.chromium.org/974403002/diff/1/shell/application_manager/ap...
File shell/application_manager/application_manager.cc (right):

https://codereview.chromium.org/974403002/diff/1/shell/application_manager/ap...
shell/application_manager/application_manager.cc:303: if
(url_to_native_options_.find(requested_url) !=
hmm, I would think that options would apply to the resolved url (possibly
post-redirection) since they're setting things about a particular
implementation. is there a reason to use the requested url here? is it just
easier to spot things by their logical name?

[viettrungluu, 2015-03-04 21:12:53]

On 2015/03/04 20:55:25, jamesr wrote:
>
https://codereview.chromium.org/974403002/diff/1/shell/application_manager/ap...
> File shell/application_manager/application_manager.cc (right):
> 
>
https://codereview.chromium.org/974403002/diff/1/shell/application_manager/ap...
> shell/application_manager/application_manager.cc:303: if
> (url_to_native_options_.find(requested_url) !=
> hmm, I would think that options would apply to the resolved url (possibly
> post-redirection) since they're setting things about a particular
> implementation. is there a reason to use the requested url here? is it just
> easier to spot things by their logical name?

That's a good question. My response:
http://www.quickmeme.com/img/53/5399f8caf0a80d8c9eb95c941e10d3eae4f3242712bdb...

Let me ponder this.

[viettrungluu, 2015-03-04 22:13:08]

PTAL. (I still don't know what I'm doing.)

[jamesr, 2015-03-04 22:16:15]

lgtm but please explain the scheme here in the patch description or we're not
gonna remember it ever

https://codereview.chromium.org/974403002/diff/20001/shell/application_manage...
File shell/application_manager/application_manager.h (right):

https://codereview.chromium.org/974403002/diff/20001/shell/application_manage...
shell/application_manager/application_manager.h:249: // Note: The keys are
mapped/resolved URLs.
nit: mapped+resolved URLs? these are things that have had both operations
performed (if applicable) not just one or the other

[viettrungluu, 2015-03-04 22:36:31]

Thanks.

On 2015/03/04 22:16:15, jamesr wrote:
> lgtm but please explain the scheme here in the patch description or we're not
> gonna remember it ever

Done.

> 
>
https://codereview.chromium.org/974403002/diff/20001/shell/application_manage...
> File shell/application_manager/application_manager.h (right):
> 
>
https://codereview.chromium.org/974403002/diff/20001/shell/application_manage...
> shell/application_manager/application_manager.h:249: // Note: The keys are
> mapped/resolved URLs.
> nit: mapped+resolved URLs? these are things that have had both operations
> performed (if applicable) not just one or the other

Done (more or less).

[viettrungluu, 2015-03-04 22:37:31]

Committed patchset #3 (id:40001) manually as
fbf0a4ee9c117d4ea25ea2654ff5aaac3936ab40 (presubmit successful).

[qsr, 2015-03-05 14:47:51]

qsr@chromium.org changed reviewers:
+ qsr@chromium.org

[qsr, 2015-03-05 14:47:53]

https://codereview.chromium.org/974403002/diff/40001/shell/application_manage...
File shell/application_manager/application_manager.cc (right):

https://codereview.chromium.org/974403002/diff/40001/shell/application_manage...
shell/application_manager/application_manager.cc:303: if
(url_to_native_options_.find(fetcher->GetURL()) !=
As you put it in the comment in SetNativeOptionsForURL, you need to remove the
query string here (at the other place, I would just DCHECK that there is no
query string).

[viettrungluu, 2015-03-05 18:30:10]

https://codereview.chromium.org/974403002/diff/40001/shell/application_manage...
File shell/application_manager/application_manager.cc (right):

https://codereview.chromium.org/974403002/diff/40001/shell/application_manage...
shell/application_manager/application_manager.cc:303: if
(url_to_native_options_.find(fetcher->GetURL()) !=
On 2015/03/05 14:47:52, qsr wrote:
> As you put it in the comment in SetNativeOptionsForURL, you need to remove the
> query string here (at the other place, I would just DCHECK that there is no
> query string).

That's easier now that you've landed your change. ;)

I'll send you a change for this....