Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_common.h

Issue 974323002: Componentize autofill dialog common code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing includes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_common.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_common.h b/chrome/browser/ui/autofill/autofill_dialog_common.h
index 626d676b01e38a791e3c19fdf391cacb3837fb4a..f1836fa51d47fe99b3f03cdbc481d6f02cde78a7 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_common.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_common.h
@@ -7,8 +7,7 @@
#include "chrome/browser/ui/autofill/autofill_dialog_types.h"
#include "components/autofill/core/browser/autofill_metrics.h"
-#include "components/autofill/core/browser/autofill_type.h"
-#include "components/autofill/core/browser/field_types.h"
+#include "components/autofill/core/browser/dialog_section.h"
namespace autofill {
class AutofillProfile;
@@ -27,28 +26,6 @@ enum AddressType {
ADDRESS_TYPE_SHIPPING,
};
-// Returns true if |type| should be shown when |field_type| has been requested.
-// This filters the types that we fill into the page to match the ones the
-// dialog actually cares about, preventing rAc from giving away data that an
-// AutofillProfile or other data source might know about the user which isn't
-// represented in the dialog.
-bool ServerTypeEncompassesFieldType(ServerFieldType type,
- const AutofillType& field_type);
-
-// Returns true if |type| in the given |section| should be used for a
-// site-requested |field|.
-bool ServerTypeMatchesField(DialogSection section,
- ServerFieldType type,
- const AutofillField& field);
-
-// Returns true if the |type| belongs to the CREDIT_CARD field type group.
-bool IsCreditCardType(ServerFieldType type);
-
-// Constructs |inputs| from the array of inputs in |input_template|.
-void BuildInputs(const DetailInput input_template[],
- size_t template_size,
- DetailInputs* inputs);
-
// Returns the AutofillMetrics::DIALOG_UI_*_ITEM_ADDED metric corresponding
// to the |section|.
AutofillMetrics::DialogUiEvent DialogSectionToUiItemAddedEvent(
@@ -59,9 +36,6 @@ AutofillMetrics::DialogUiEvent DialogSectionToUiItemAddedEvent(
AutofillMetrics::DialogUiEvent DialogSectionToUiSelectionChangedEvent(
DialogSection section);
-// Gets just the |type| attributes from each DetailInput.
-std::vector<ServerFieldType> TypesFromInputs(const DetailInputs& inputs);
-
} // namespace common
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698