Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 974273002: Serializer: fix false negative in hashmap lookups. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: fix false negative in hashmap lookups. If we use HashMap::Lookup with insert=true, the returned entry may have NULL as value. This could either mean that the value is 0, or that the entry has just been inserted. This ambiguity can cause false negatives in PartialCacheIndexMap::LookupOrInsert. Also fix a TODO. R=vogelheim@chromium.org Committed: https://crrev.com/dbecf20d65460a2856563b46f6f0267805cae64f Cr-Commit-Position: refs/heads/master@{#26994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M src/serialize.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/serialize.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 9 months ago (2015-03-04 14:39:45 UTC) #1
Yang
On 2015/03/04 14:39:45, Yang wrote: The snapshot blob shrinks very slightly after this.
5 years, 9 months ago (2015-03-04 14:41:51 UTC) #2
vogelheim
lgtm
5 years, 9 months ago (2015-03-04 15:04:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974273002/1
5 years, 9 months ago (2015-03-04 15:07:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 15:36:06 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 15:36:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbecf20d65460a2856563b46f6f0267805cae64f
Cr-Commit-Position: refs/heads/master@{#26994}

Powered by Google App Engine
This is Rietveld 408576698