src/compiler/basic-block-instrumentor.cc - Issue 974213002: Extract ParseInfo from CompilationInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/basic-block-instrumentor.cc

Issue 974213002: Extract ParseInfo from CompilationInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/basic-block-instrumentor.cc

diff --git a/src/compiler/basic-block-instrumentor.cc b/src/compiler/basic-block-instrumentor.cc

index 54f9d6b059ab3b50a9f0f454eaf4e096d42879af..00291bba488bf63b66b32ce8945bec232628c68a 100644

--- a/src/compiler/basic-block-instrumentor.cc

+++ b/src/compiler/basic-block-instrumentor.cc

@@ -55,8 +55,7 @@ BasicBlockProfiler::Data* BasicBlockInstrumentor::Instrument(

BasicBlockProfiler::Data* data =

info->isolate()->GetOrCreateBasicBlockProfiler()->NewData(n_blocks);

// Set the function name.

- if (!info->shared_info().is_null() &&

- info->shared_info()->name()->IsString()) {

+ if (info->has_shared_info() && info->shared_info()->name()->IsString()) {

std::ostringstream os;

String::cast(info->shared_info()->name())->PrintUC16(os);

data->SetFunctionName(&os);