Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/scopes.cc

Issue 974213002: Extract ParseInfo from CompilationInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scopes.h ('k') | src/serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scopes.cc
diff --git a/src/scopes.cc b/src/scopes.cc
index 97a89431f39e1e824acda5d8d3a85c46df568c3c..ee5c51261076cae336d72129db575a6f7370eadb 100644
--- a/src/scopes.cc
+++ b/src/scopes.cc
@@ -4,13 +4,12 @@
#include "src/v8.h"
-#include "src/scopes.h"
-
#include "src/accessors.h"
#include "src/bootstrapper.h"
-#include "src/compiler.h"
#include "src/messages.h"
+#include "src/parser.h"
#include "src/scopeinfo.h"
+#include "src/scopes.h"
namespace v8 {
namespace internal {
@@ -248,8 +247,9 @@ Scope* Scope::DeserializeScopeChain(Isolate* isolate, Zone* zone,
}
-bool Scope::Analyze(CompilationInfo* info) {
+bool Scope::Analyze(ParseInfo* info) {
DCHECK(info->function() != NULL);
+ DCHECK(info->scope() == NULL);
Scope* scope = info->function()->scope();
Scope* top = scope;
@@ -279,7 +279,7 @@ bool Scope::Analyze(CompilationInfo* info) {
}
#endif
- info->PrepareForCompilation(scope);
+ info->set_scope(scope);
return true;
}
@@ -639,7 +639,7 @@ void Scope::CollectStackAndContextLocals(ZoneList<Variable*>* stack_locals,
}
-bool Scope::AllocateVariables(CompilationInfo* info, AstNodeFactory* factory) {
+bool Scope::AllocateVariables(ParseInfo* info, AstNodeFactory* factory) {
// 1) Propagate scope information.
bool outer_scope_calls_sloppy_eval = false;
if (outer_scope_ != NULL) {
@@ -1055,7 +1055,7 @@ Variable* Scope::LookupRecursive(VariableProxy* proxy,
}
-bool Scope::ResolveVariable(CompilationInfo* info, VariableProxy* proxy,
+bool Scope::ResolveVariable(ParseInfo* info, VariableProxy* proxy,
AstNodeFactory* factory) {
DCHECK(info->script_scope()->is_script_scope());
@@ -1137,7 +1137,7 @@ bool Scope::ResolveVariable(CompilationInfo* info, VariableProxy* proxy,
}
-bool Scope::ResolveVariablesRecursively(CompilationInfo* info,
+bool Scope::ResolveVariablesRecursively(ParseInfo* info,
AstNodeFactory* factory) {
DCHECK(info->script_scope()->is_script_scope());
« no previous file with comments | « src/scopes.h ('k') | src/serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698