Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: src/runtime/runtime-internal.cc

Issue 974213002: Extract ParseInfo from CompilationInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-internal.cc
diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc
index d701561c2f9d7ac2463be00bfab1e016f9a87e5d..460ea9c52114f8c1d634a2ea6025788f6922ff1b 100644
--- a/src/runtime/runtime-internal.cc
+++ b/src/runtime/runtime-internal.cc
@@ -179,18 +179,13 @@ RUNTIME_FUNCTION(Runtime_RenderCallSite) {
if (location.start_pos() == -1) return isolate->heap()->empty_string();
Zone zone;
+ ParseInfo info(&zone);
if (location.function()->shared()->is_function()) {
- CompilationInfo info(location.function(), &zone);
- if (!Parser::ParseStatic(&info)) {
- isolate->clear_pending_exception();
- return isolate->heap()->empty_string();
- }
- CallPrinter printer(isolate, &zone);
- const char* string = printer.Print(info.function(), location.start_pos());
- return *isolate->factory()->NewStringFromAsciiChecked(string);
+ info.InitializeFromJSFunction(location.function());
+ } else {
+ info.InitializeFromScript(location.script());
}
- CompilationInfo info(location.script(), &zone);
if (!Parser::ParseStatic(&info)) {
isolate->clear_pending_exception();
return isolate->heap()->empty_string();

Powered by Google App Engine
This is Rietveld 408576698