Chromium Code Reviews

Unified Diff: src/hydrogen.cc

Issue 974213002: Extract ParseInfo from CompilationInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index d74942f46a86a248bc6a4b9a9006c7e902525fd2..545119c2a4478b3e84a819ac566b6f140cde1c9b 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5297,7 +5297,7 @@ HValue* HOptimizedGraphBuilder::BuildContextChainWalk(Variable* var) {
void HOptimizedGraphBuilder::VisitVariableProxy(VariableProxy* expr) {
if (expr->is_this()) {
- current_info()->set_this_has_uses(true);
+ current_info()->parse_info()->set_this_has_uses(true);
}
DCHECK(!HasStackOverflow());
@@ -7841,12 +7841,17 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
}
// Parse and allocate variables.
- CompilationInfo target_info(target, zone());
// Use the same AstValueFactory for creating strings in the sub-compilation
// step, but don't transfer ownership to target_info.
- target_info.SetAstValueFactory(top_info()->ast_value_factory(), false);
+ ParseInfo parse_info(zone());
+ parse_info.InitializeFromJSFunction(target);
+ parse_info.set_ast_value_factory(
+ top_info()->parse_info()->ast_value_factory());
+ parse_info.set_ast_value_factory_owned(false);
+
+ CompilationInfo target_info(&parse_info);
Handle<SharedFunctionInfo> target_shared(target->shared());
- if (!Compiler::ParseAndAnalyze(&target_info)) {
+ if (!Compiler::ParseAndAnalyze(target_info.parse_info())) {
if (target_info.isolate()->has_pending_exception()) {
// Parse or scope error, never optimize this function.
SetStackOverflow();

Powered by Google App Engine