Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: Source/core/html/canvas/WebGL2RenderingContextBase.h

Issue 974203002: update getTexParameter for WebGL 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressed zmo@'s feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGL2RenderingContextBase.h
diff --git a/Source/core/html/canvas/WebGL2RenderingContextBase.h b/Source/core/html/canvas/WebGL2RenderingContextBase.h
index bbcc8de66f29ef2be8bd9d36b89814b928a6cd1d..7ba0cb03ab51fe5250f15f562b703032c4eadf83 100644
--- a/Source/core/html/canvas/WebGL2RenderingContextBase.h
+++ b/Source/core/html/canvas/WebGL2RenderingContextBase.h
@@ -159,6 +159,9 @@ public:
GLboolean isVertexArray(WebGLVertexArrayObjectOES*);
void bindVertexArray(WebGLVertexArrayObjectOES*);
+ /* WebGLRenderingContextBase APIs overrides */
+ ScriptValue getTexParameter(ScriptState*, GLenum target, GLenum pname) override;
+
DECLARE_VIRTUAL_TRACE();
protected:
@@ -166,9 +169,11 @@ protected:
bool validateClearBuffer(const char* functionName, GLenum buffer, GLsizei length);
- /* WebGLRenderingContextBase overrides */
+ /* WebGLRenderingContextBase helper functions overrides */
bool validateCapability(const char* functionName, GLenum) override;
bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, WebGLBuffer*) override;
+
+ WebGLTexture* validateTextureBinding(const char* functionName, GLenum target, bool useSixEnumsForCubeMap) override;
};
DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context,

Powered by Google App Engine
This is Rietveld 408576698